Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed suffix like _pymc, _blackjax, etc from book2 notebooks #940

Merged
merged 10 commits into from
Jun 27, 2022
Merged

Removed suffix like _pymc, _blackjax, etc from book2 notebooks #940

merged 10 commits into from
Jun 27, 2022

Conversation

karm-patel
Copy link
Collaborator

Description

  1. Removed following suffixes from 23 notebooks.
["tfp","blackjax","jax","pyro","numpyro","pymc3","pymc","sklearn","flax"]
  1. I've updated the notebook name in book2 .tex files, please see this PR:https://github.com/probml/bookv2/pull/80
  2. I've also updated the other notebooks wherever these old names were referred.

Note: This change will break 23 URLs in the current notebook.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@murphyk
Copy link
Member

murphyk commented Jun 26, 2022

@karm-patel
Copy link
Collaborator Author

there is some kind of error: https://github.com/probml/pyprobml/runs/7063022379?check_suite_focus=true

Dr. @murphyk, Yes right, I'm resolving these errors in other threads, currently, I'm merging this PR so we can test dead URLs in bookv2's workflow.

@karm-patel karm-patel merged commit cf05b06 into probml:master Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants