Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Book2 notebooks: replaced camel case to snake case #942

Merged
merged 3 commits into from
Jun 27, 2022
Merged

Book2 notebooks: replaced camel case to snake case #942

merged 3 commits into from
Jun 27, 2022

Conversation

karm-patel
Copy link
Collaborator

Description

Issue

#931

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@murphyk
Copy link
Member

murphyk commented Jun 27, 2022

execute_current_PR_notebooks_MUST_PASS (pull_request) fails

@karm-patel
Copy link
Collaborator Author

karm-patel commented Jun 27, 2022

execute_current_PR_notebooks_MUST_PASS (pull_request) fails

Dr. @murphyk Yes right, but you can ignore this check in my PRs :) because anyway I'm resolving these errors in separate threads. like #935, #936

@karm-patel karm-patel merged commit c5512bd into probml:master Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants