Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add invite-contributors to list of apps #78

Merged
merged 2 commits into from
Oct 19, 2017
Merged

Add invite-contributors to list of apps #78

merged 2 commits into from
Oct 19, 2017

Conversation

erickzhao
Copy link
Contributor

@erickzhao erickzhao commented Oct 17, 2017

Hey there!

Made this bot in response to a Hacktoberfest issue: http://github.com/reactiveui/ReactiveUI/issues/1501

Didn't really know how to add a screenshot of what the bot does, though. :/

Copy link
Contributor

@bkeepers bkeepers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really awesome! The code looks really good.

I don't love the "badge" name, mostly because that is typically what people call the things they add to their README (e.g. the travis build that is at the top of the readme for this app). How attached are you to the name?

@erickzhao
Copy link
Contributor Author

erickzhao commented Oct 17, 2017

Hi @bkeepers, glad to see that you like the app! I do see the potential confusion that the name could cause, though. Maybe something more straightforward like org-inviter or invite? (Suggestions also appreciated 😉. )

By the way, did you give the talk on Probot during GitHub Universe? I actually stumbled upon the live stream midway through making the bot and it was pretty helpful. 😃

@bkeepers
Copy link
Contributor

Suggestions also appreciated 😉.

invite-contributors? 🤷‍♂️

By the way, did you give the talk on Probot during GitHub Universe? I actually stumbled upon the live stream midway through making the bot and it was pretty helpful. 😃

No, @jbjonesjr did! It was great.

erickzhao added a commit to erickzhao/invite-contributors that referenced this pull request Oct 18, 2017
@erickzhao erickzhao changed the title Add Badge to list of apps Add invite-contributors to list of apps Oct 18, 2017
@erickzhao
Copy link
Contributor Author

Updated the repository name! You can find it at https://github.com/erickzhao/invite-contributors

:)

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants