Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version option to client CLI #105

Merged
merged 2 commits into from
Mar 31, 2019

Conversation

tjkorthal
Copy link
Contributor

Pulls in the version number from package.json and is returned when running smee with the -v or --version option.
Fixes #95

Copy link
Member

@JasonEtco JasonEtco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay here - looks great, thanks for the addition 🙏 However, we'll track version bumps separately from PRs to publish additions in groups. Would you mind removing the change to the package.json?

Copy link
Member

@JasonEtco JasonEtco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scratch that - I'm publishing 1.1.0 right now anyway, so I'll go ahead and merge this. Thanks for the addition @tjkorthal! ❤️

@JasonEtco JasonEtco merged commit 46f41dd into probot:master Mar 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants