Skip to content
This repository has been archived by the owner on May 20, 2023. It is now read-only.

Make default comment friendlier and actionable (fixes #67) #162

Merged
merged 3 commits into from
Aug 23, 2019

Conversation

waldyrious
Copy link
Contributor

@waldyrious waldyrious commented Sep 10, 2018

The default message posted by the bot is unnecessarily harsh and final-sounding, which has resulted in a lot of grief, summarized in #67.

Interestingly enough, even this repo decided against using the default message and has been using a friendlier and more constructive message for a while.

This change makes that message the default, so that other communities using this bot get a more positive experience out of the box.

@christianbundy
Copy link
Contributor

@bkeepers Is there anything I can do to help move this forward? I'd love to see this merged.

@stale
Copy link

stale bot commented Mar 11, 2019

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@stale stale bot added the wontfix label Mar 11, 2019
@dwijnand
Copy link

I think this is just awaiting a review and a merge.

@stale
Copy link

stale bot commented Jun 9, 2019

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@stale stale bot added the wontfix label Jun 9, 2019
@dwijnand
Copy link

dwijnand commented Jun 9, 2019

I think this is just awaiting a review and a merge.

@Download
Copy link

@bkeepers This issue seems to need your attention...

Maybe you can invite some collaborators to help with reviewing and merging PRs?

@bkeepers
Copy link
Contributor

I am no longer involved with the project. Maybe @tcbyrd or @JasonEtco could suggest someone that can help?

@Download
Copy link

@bkeepers Ok clear, thanks!
@JasonEtco Maybe invite some more collaborators to help with reviewing/merging?

Copy link
Member

@JasonEtco JasonEtco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @waldyrious 👋 Apologies for the delay. I think this is a welcome change. I've left a note about clarifying the comment, and making sure that folks that see it understand what will happen. If you can make that change, this should be good to go!

lib/schema.js Outdated Show resolved Hide resolved
@christianbundy
Copy link
Contributor

Maybe we could just concat the two?

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@waldyrious
Copy link
Contributor Author

Thanks @JasonEtco and @christianbundy for the suggestions. I re-added the note at the end, but removed the "Thank you for your contributions" because it sounds a little passive-aggressive to me coming after a "this issue will be closed" message. Let me know what you think. :)

@waldyrious
Copy link
Contributor Author

waldyrious commented Aug 22, 2019

Also, I wonder if moving the placement of "automatic" to the closure sentence could help reduce the chance of perceived harshness, by clarifying that no decision for closure has been made yet:

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been marked as stale because it has not had recent activity. It will be automatically closed if no further activity occurs.

WDYT?

Copy link
Member

@JasonEtco JasonEtco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's perfect @waldyrious! Thanks for the contribution, and thank you for your patience in getting this merged!

@JasonEtco JasonEtco merged commit 44d5e52 into probot:master Aug 23, 2019
@waldyrious waldyrious deleted the patch-1 branch August 23, 2019 09:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants