Skip to content
This repository has been archived by the owner on May 20, 2023. It is now read-only.

Add whitelist support #169

Merged
merged 4 commits into from
Mar 20, 2019
Merged

Add whitelist support #169

merged 4 commits into from
Mar 20, 2019

Conversation

scribblemaniac
Copy link
Contributor

@scribblemaniac scribblemaniac commented Oct 21, 2018

This fixes the merge conflicts from #37 and updates it with some of the recent changes. Hopefully we can finally get this merged.

I have run the automated tests on this and everything passes, but I have not tested to see if this actually works as intended because it seems like quite a process just to get a testing environment set up.

Closes #22
Closes #37


View rendered README.md

@stale
Copy link

stale bot commented Feb 7, 2019

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@stale stale bot added the wontfix label Feb 7, 2019
@scribblemaniac
Copy link
Contributor Author

Oh the irony. It's just sitting here, ready to merge for months. Is there any reason why this is getting completely ignored?

@stale stale bot removed the wontfix label Feb 7, 2019
Copy link
Contributor

@tcbyrd tcbyrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scribblemaniac Apologies for letting this get....Stale 🤖

I'm working on updating everything to newest Probot/Octokit and would like to add this feature. I have one small suggestion on the wording, but otherwise I think we can get this merged and I'll work to incorporate it into v2.0.

README.md Outdated Show resolved Hide resolved
@tcbyrd tcbyrd added this to the v2.0 milestone Mar 14, 2019
Co-Authored-By: scribblemaniac <scribblemaniac@users.noreply.github.com>
@scribblemaniac
Copy link
Contributor Author

I have applied your suggestion, and am looking forward to seeing some progress on this. 🙂

@tcbyrd tcbyrd merged commit e3c53eb into probot:master Mar 20, 2019
@tcbyrd
Copy link
Contributor

tcbyrd commented Mar 20, 2019

Thanks!

@tcbyrd
Copy link
Contributor

tcbyrd commented Mar 20, 2019

Also just FYI it will probably be a few days before I get a chance to test it out and deploy it to production. Hopefully by this weekend.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Whitelist labels
3 participants