[REFACTOR] BpmnCanvas manages icon style and some 'icon origin' #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbouffard
added
depends on another PR ⚠️
7 tasks
csouchet
added
rebase needed 💥
Manage - icon origin from top left shape: this avoids performing a 'hard' translate. Such translate has side effects for subsequent painting: the origin has moved so it would require to know that a back translate is needed. This will help when managing activity markers. - icon style: this currently introduces duplication with `IconPainter` that will be removed when IconPainter will always use icon style
tbouffard
force-pushed
the
refactor/icon_origin_without_hard_translate_and_update_style_in_tpmn_canvas
branch
from
60632c8
to
bc867c7
Compare
tbouffard
changed the title
tbouffard
removed
the
rebase needed 💥
csouchet
approved these changes
Jul 8, 2020
aibcmars
approved these changes
Jul 8, 2020
…e_and_update_style_in_tpmn_canvas
tbouffard
deleted the
refactor/icon_origin_without_hard_translate_and_update_style_in_tpmn_canvas
branch
|
Note: icons touched by this refactoring
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manage
Such translate has side effects for subsequent painting: the origin has moved
so it would require to know that a back translate is needed. This will help
when managing activity markers.
IconPainterthatwill be removed when IconPainter will always use icon style
Covers #247