[FEAT] Display Text Annotation #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aibcmars
added
the
BPMN support
aibcmars
changed the title
csouchet
reviewed
Jul 7, 2020
csouchet
requested changes
Jul 7, 2020
There was a problem hiding this comment.
Need to modify the BPMNlabel getting in DiagramConverter, and modify the tests:
- test/unit/component/parser/json/BpmnJsonParser.label.bounds.test.ts
- test/unit/component/parser/json/BpmnJsonParser.label.font.test.ts
- test/unit/component/parser/json/BpmnJsonParser.label.test.ts
to be generic and loop on a list of process element with Shape as parameter, like in test/unit/component/parser/json/BpmnJsonParser.sequenceFlow.default.test.ts 😉
csouchet
reviewed
Jul 7, 2020
test/unit/component/parser/json/BpmnJsonParser.label.bounds.test.ts
Outdated
Show resolved
Hide resolved
csouchet
reviewed
Jul 7, 2020
test/unit/component/parser/json/BpmnJsonParser.label.font.test.ts
Outdated
Show resolved
Hide resolved
csouchet
reviewed
Jul 7, 2020
csouchet
reviewed
Jul 7, 2020
csouchet
reviewed
Jul 7, 2020
csouchet
requested changes
Jul 7, 2020
copy paste error fixed Co-authored-by: Souchet Céline <4921914+csouchet@users.noreply.github.com>
csouchet
approved these changes
Jul 7, 2020
|
|
With B.1.0.bpmn
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display Text Annotation
closes #94