Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] Detect Interrupting Signal Intermediate Event Attached to an Activity Boundary #420

Merged
merged 15 commits into from
Jul 15, 2020
Merged

[FEAT] Detect Interrupting Signal Intermediate Event Attached to an Activity Boundary #420

merged 15 commits into from
Jul 15, 2020

Conversation

csouchet
Copy link
Member

@csouchet csouchet commented Jul 15, 2020 •
edited
Loading

Closes #318

@csouchet csouchet added enhancement New feature or request BPMN support Something about the BPMN specification that the lib is already supporting or will support depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first labels Jul 15, 2020
@csouchet csouchet marked this pull request as ready for review July 15, 2020 10:20
@csouchet csouchet removed the depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first label Jul 15, 2020
tbouffard
tbouffard approved these changes Jul 15, 2020
View reviewed changes
Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Json parsing unit tests already existed.

@csouchet csouchet merged commit 7b390e0 into master Jul 15, 2020
@csouchet csouchet deleted the 318-Detect_Interrupting_Signal_Boundary_Intermediate_Event branch July 15, 2020 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbouffard tbouffard tbouffard approved these changes

Assignees
No one assigned
Labels
BPMN support Something about the BPMN specification that the lib is already supporting or will support enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] Detect Interrupting Signal Intermediate Event Attached to an Activity Boundary
2 participants
@csouchet @tbouffard