[FEAT] Detect the Loop Marker of an activity #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csouchet
added
enhancement
tbouffard
reviewed
Aug 4, 2020
| } | ||
|
|
||
| protected paintMarkerIcon(paintParameter: PaintParameter): void { | ||
| switch (StyleUtils.getBpmnMarker(this.style)) { |
There was a problem hiding this comment.
❓ with this implementation we only support a single markers, but we know that we will support several later. This is because you plan we will do it later?
I see an issue not doing it now, we will need to change lot of code prior being able to support several markers, so a refactoring will be need 1st. Can we consider doing it now instead?
In addition, we could also consider the activity collapsed icon as a marker as well
There was a problem hiding this comment.
Decision after discussion with @csouchet
- we keep this PR as it is now
- 2 others PR will be created
- a 1st one, soon to manage marker and expanded 'icon' with the same way in the mxGraph style. This will prepare management of other markers, helps to manage markers position later
- prior supporting a new marker (probably multi-instantiation), the model objects will be updated to store several markers
tbouffard
requested changes
Aug 4, 2020
Added 😄 |
tbouffard
approved these changes
Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #145
Expected
At commit c9b5223