Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Render Instantiating Receive Task #536

Merged
merged 7 commits into from
Aug 18, 2020

Conversation

tbouffard
Copy link
Member

Closes #511
Introduced a temporary way to generate task icon with a fixed size. This will be reworked and reviewed as part of #211 and #465

Icon rendering on task with various sizes

Using diagram from process-analytics/bpmn-visualization-examples#47
image

Icon rendering comparisons between all supported tasks

Using a diagram adapted from the non-regression tasks diagram from #523
image

@tbouffard tbouffard added enhancement New feature or request BPMN rendering Something about the way the lib is rendering BPMN elements labels Aug 18, 2020
@tbouffard tbouffard force-pushed the 511-render_instantiating_receive_task branch from 2706744 to 92bb411 Compare August 18, 2020 07:28
Copy link
Contributor

@aibcmars aibcmars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbouffard tbouffard merged commit 7219e66 into master Aug 18, 2020
@tbouffard tbouffard deleted the 511-render_instantiating_receive_task branch August 18, 2020 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BPMN rendering Something about the way the lib is rendering BPMN elements enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Render Instantiating Receive task
2 participants