Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TEST] Fix id convention in model-complete-semantic.bpmn #678

Merged
merged 14 commits into from
Oct 2, 2020
Merged

[TEST] Fix id convention in model-complete-semantic.bpmn #678

merged 14 commits into from
Oct 2, 2020

Conversation

csouchet
Copy link
Member

No description provided.

@csouchet csouchet force-pushed the fix_id_convention_in_model-complete-semantic.bpmn branch from 10dc3b7 to 6d1b1d0 Compare September 30, 2020 12:32
@csouchet csouchet added depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first refactoring Code refactoring WIP 🚧 Pull request in progress and/or not ready for review. Used in addition to marking it as draft labels Sep 30, 2020
@csouchet csouchet force-pushed the fix_id_convention_in_model-complete-semantic.bpmn branch from d718e98 to c008467 Compare September 30, 2020 15:20
@tbouffard tbouffard mentioned this pull request Sep 30, 2020
Merged
@csouchet csouchet force-pushed the fix_id_convention_in_model-complete-semantic.bpmn branch from c008467 to 75233c9 Compare September 30, 2020 15:51
@csouchet csouchet removed depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first WIP 🚧 Pull request in progress and/or not ready for review. Used in addition to marking it as draft labels Sep 30, 2020
@csouchet csouchet marked this pull request as ready for review September 30, 2020 16:02
@csouchet csouchet force-pushed the fix_id_convention_in_model-complete-semantic.bpmn branch from c3e7c7e to c309648 Compare September 30, 2020 16:08
@csouchet csouchet changed the title [INFRA] Fix id convention in model-complete-semantic.bpmn [TEST] Fix id convention in model-complete-semantic.bpmn Oct 1, 2020
@csouchet csouchet force-pushed the fix_id_convention_in_model-complete-semantic.bpmn branch from c309648 to 72df6da Compare October 1, 2020 10:04
@csouchet csouchet added this to the 0.4.0 milestone Oct 1, 2020
@tbouffard
Copy link
Member

Compensation events are now placed at a dedicated position

image

and business tasks as well

image

tbouffard
tbouffard approved these changes Oct 2, 2020
View reviewed changes
Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Id and labels names are now consistent. Thanks for that and having improved the positions of the elements in model-complete-semantic.bpmn

test/e2e/mxGraph.model.test.ts
});
expectModelContainsShape('task_with_loop', {
expectModelContainsShape('task_id', { kind: ShapeBpmnElementKind.TASK, label: 'Task' });
expectModelContainsShape('task_with_loop_id', {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ do you remember why you removed the expectation about font here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid to duplicate the same expectation about font (and configuration on diagram), I just check it on task_with_flows_id task.

@tbouffard tbouffard removed this from the 0.4.0 milestone Oct 2, 2020
@tbouffard tbouffard merged commit ccfaf15 into master Oct 2, 2020
@tbouffard tbouffard deleted the fix_id_convention_in_model-complete-semantic.bpmn branch October 2, 2020 13:32
@csouchet csouchet added the hacktoberfest-accepted Accepted Pull Request during Hacktoberfest label Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbouffard tbouffard tbouffard approved these changes

@aibcmars aibcmars Awaiting requested review from aibcmars

Assignees
No one assigned
Labels
hacktoberfest-accepted Accepted Pull Request during Hacktoberfest refactoring Code refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@csouchet @tbouffard