Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INFRA] Allow e2e tests to pass on gitpod #686

Merged

Conversation

aibcmars
Copy link
Contributor

@aibcmars aibcmars commented Oct 1, 2020

Due to the fact that default image lacks certain libraries needed for the puppeteer to lanch, the new enhanced Dockerfile was created.

@aibcmars aibcmars added the robustness Improvement or fix about performance, cutting edge, non happy path, ... label Oct 1, 2020
@tbouffard
Copy link
Member

tbouffard commented Oct 2, 2020

Running a fresh workspace, the npm install script was not run.
This is probably because there was no .gitpod.yml in the master branch.

After having switched to the branch of this pr that has the init tasks, run npm install, the e2e tests fail.

I have removed the node_modules, then restarted the workspace. The node_modules folder is not created.
e2e tests still fail.

@aibcmars
Copy link
Contributor Author

aibcmars commented Oct 5, 2020

Running a fresh workspace, the npm install script was not run.
This is probably because there was no .gitpod.yml in the master branch.

After having switched to the branch of this pr that has the init tasks, run npm install, the e2e tests fail.

I have removed the node_modules, then restarted the workspace. The node_modules folder is not created.
e2e tests still fail.

Maybe there is some issues with running Gitpod from PR?

I have just tested by running it from my GitHub branch and tests are passing.
https://github.com/aibcmars/bpmn-visualization-js/tree/infra-gitpod_e2e_tests_fix

image

@tbouffard
Copy link
Member

tbouffard commented Oct 5, 2020

Ok, I will retest with a fresh workspace created from the branch of this PR as described in https://www.gitpod.io/docs/context-urls/#branch-context
https://gitpod.io/#https://github.com/aibcmars/bpmn-visualization-js/tree/infra-gitpod_e2e_tests_fix

@tbouffard
Copy link
Member

tbouffard commented Oct 5, 2020

✔️ Creating the workspace with the branch of this PR works fine
The workspace creation is a bit more slower than before because of the need for rebuilding the Docker image. We may document this.

npm install is run at workspace startup

I got some errors in the log when running e2e tests, but tests pass, so we can check this later

DevTools listening on ws://127.0.0.1:37159/devtools/browser/0b3bc7ae-2c8a-4798-a632-4baeeae23834
[1005/093724.729728:ERROR:zygote_host_impl_linux.cc(263)] Failed to adjust OOM score of renderer with pid 2871: Permission denied (13)
[1005/093724.732990:ERROR:zygote_host_impl_linux.cc(263)] Failed to adjust OOM score of renderer with pid 2875: Permission denied (13)
...
1005/093753.206752:ERROR:zygote_host_impl_linux.cc(263)] Failed to adjust OOM score of renderer with pid 3267: Permission denied (13)

Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works fine, thanks

@csouchet csouchet merged commit 3325495 into process-analytics:master Oct 5, 2020
@tbouffard tbouffard added chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) and removed robustness Improvement or fix about performance, cutting edge, non happy path, ... labels Oct 5, 2020
@csouchet csouchet added the hacktoberfest-accepted Accepted Pull Request during Hacktoberfest label Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) hacktoberfest-accepted Accepted Pull Request during Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants