-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INFRA] Allow e2e tests to pass on gitpod #686
[INFRA] Allow e2e tests to pass on gitpod #686
Conversation
Running a fresh workspace, the npm install script was not run. After having switched to the branch of this pr that has the init tasks, run npm install, the e2e tests fail. I have removed the node_modules, then restarted the workspace. The node_modules folder is not created. |
Maybe there is some issues with running Gitpod from PR? I have just tested by running it from my GitHub branch and tests are passing. |
Ok, I will retest with a fresh workspace created from the branch of this PR as described in https://www.gitpod.io/docs/context-urls/#branch-context |
✔️ Creating the workspace with the branch of this PR works fine
I got some errors in the log when running e2e tests, but tests pass, so we can check this later
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, works fine, thanks
Due to the fact that default image lacks certain libraries needed for the puppeteer to lanch, the new enhanced Dockerfile was created.