Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INFRA] Provide an IIFE bundle #690

Merged
merged 5 commits into from
Oct 2, 2020
Merged

[INFRA] Provide an IIFE bundle #690

merged 5 commits into from
Oct 2, 2020

Conversation

tbouffard
Copy link
Member

@tbouffard tbouffard commented Oct 2, 2020 •
edited
Loading

The IIFE bundle can be manually tested by opening the local /test-bundle/lib-integration-iife.html file in a web browser

closes #601
based on POC #645

@tbouffard tbouffard added the chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) label Oct 2, 2020
@tbouffard
Copy link
Member Author

✔️ tests done with 1c1339e

  • build bundle and display the test bundle page
  • build demo and display the demo page
  • build the project and ensure files are unchanged
  • watch the project and check generated files (sourcemap still exists)

The rollup configuration is more messy, but as #594 will be implemented soon, the refactoring will be easier to manage once we have the need for more bundles (more use case to cover).

@tbouffard tbouffard marked this pull request as ready for review October 2, 2020 11:36
@csouchet csouchet merged commit 80c06bd into master Oct 2, 2020
@csouchet csouchet deleted the infra/601-provide-IIFE-bundle branch October 2, 2020 12:27
@csouchet csouchet added the hacktoberfest-accepted Accepted Pull Request during Hacktoberfest label Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csouchet csouchet csouchet approved these changes

@aibcmars aibcmars Awaiting requested review from aibcmars

Assignees
No one assigned
Labels
chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) hacktoberfest-accepted Accepted Pull Request during Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[INFRA] Provide an IIFE bundle
2 participants
@tbouffard @csouchet