[INFRA] Prepare publish to npmjs #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csouchet
added
the
chore
csouchet
force-pushed
the
597-Publish_to_npmjs
branch
from
685c86c
to
baf94eb
Compare
tbouffard
reviewed
Oct 2, 2020
aibcmars
reviewed
Oct 2, 2020
tbouffard
reviewed
Oct 2, 2020
| "hooks": { | ||
| "pre-commit": "tsc --noEmit && lint-staged" | ||
| } | ||
| "dependencies": { |
There was a problem hiding this comment.
👍 for having the dependencies prior tools config
| "license": "Apache-2.0", | ||
| "browser": "dist/bpmn-visualization.js", | ||
| "module": "dist/index.es.js", | ||
| "contributors": [ |
There was a problem hiding this comment.
❓ do we want to maintain this list?
There was a problem hiding this comment.
I don't think the list changes a lot.
If I understand the npm documentation, it's just the top-level maintainers : https://docs.npmjs.com/files/package.json#people-fields-author-contributors
There was a problem hiding this comment.
npm doc
npm also sets a top-level “maintainers” field with your npm user info.
Ok let's start with this list then 😃
csouchet
changed the title
Co-authored-by: Marcin Michniewicz <45601541+aibcmars@users.noreply.github.com> # Conflicts: # package.json
not needed as we are going to clean the dist folder prior building the bundles
Move all 'npm files' related fields prior to the "scripts"
tbouffard
force-pushed
the
597-Publish_to_npmjs
branch
from
d48b8e4
to
5bbbb11
Compare
tbouffard
approved these changes
Oct 5, 2020
csouchet
added
the
hacktoberfest-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
covers #597