Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TEST] Convert expectModelContainsPool to jest extension #765

Merged
merged 1 commit into from
Oct 16, 2020
Merged

[TEST] Convert expectModelContainsPool to jest extension #765

merged 1 commit into from
Oct 16, 2020

Conversation

csouchet
Copy link
Member

@csouchet csouchet commented Oct 14, 2020 •
edited
Loading

No description provided.

@csouchet csouchet added depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first refactoring Code refactoring labels Oct 14, 2020
@csouchet csouchet mentioned this pull request Oct 14, 2020
Closed
@csouchet csouchet force-pushed the refactor/convert_expectModelContainsPool_to_jest_extension branch 2 times, most recently from e36d1cf to 957c50d Compare October 14, 2020 08:21
@csouchet csouchet mentioned this pull request Oct 14, 2020
Merged
@csouchet csouchet force-pushed the refactor/convert_expectModelContainsPool_to_jest_extension branch 11 times, most recently from f7a4c3f to 435c5cc Compare October 15, 2020 14:21
@csouchet csouchet force-pushed the refactor/convert_expectModelContainsPool_to_jest_extension branch from 435c5cc to 9c9b7a2 Compare October 16, 2020 08:00
@csouchet csouchet removed the depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first label Oct 16, 2020
@csouchet csouchet marked this pull request as ready for review October 16, 2020 08:00
tbouffard
tbouffard approved these changes Oct 16, 2020
View reviewed changes
Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

test/e2e/matchers/toBeShape/index.ts
@@ -33,6 +33,10 @@ function buildExpectedStateStyle(expectedModel: ExpectedShapeModelElement): Expe
expectedStateStyle.align = expectedModel.align ? expectedModel.align : 'center';
expectedStateStyle.strokeWidth = undefined;

if ('isHorizontal' in expectedModel) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice syntax!

@csouchet csouchet merged commit 872ee0f into master Oct 16, 2020
@csouchet csouchet deleted the refactor/convert_expectModelContainsPool_to_jest_extension branch October 16, 2020 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbouffard tbouffard tbouffard approved these changes

@aibcmars aibcmars Awaiting requested review from aibcmars

Assignees
No one assigned
Labels
refactoring Code refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@csouchet @tbouffard