Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] Remove unnecessary duplicated dependency: jest-each #831

Merged
merged 1 commit into from
Oct 26, 2020

Conversation

csouchet
Copy link
Member

jest-each is include in Jest: https://jestjs.io/docs/en/api

To avoid conflict of versions, no need to specify it as dependency.

@csouchet csouchet added the chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) label Oct 26, 2020
@tbouffard
Copy link
Member

Nice, I was wondering why we needed to include this lib whereas the jest doc explain how to deal with 'each' without talking about the need of an external lib.

@csouchet
Copy link
Member Author

When I introduced it I didn't see it was on Jest library. I saw some examples on StackOverflow.
Maybe, in an old version, they was 2 differents librariries.

@csouchet csouchet marked this pull request as ready for review October 26, 2020 13:32
Copy link
Contributor

@aibcmars aibcmars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csouchet csouchet merged commit 68561d6 into master Oct 26, 2020
@csouchet csouchet deleted the remove_jest-each branch October 26, 2020 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants