Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] Fit vertically the viewport on diagram load #835

Merged
merged 2 commits into from
Oct 28, 2020
Merged

[FEAT] Fit vertically the viewport on diagram load #835

merged 2 commits into from
Oct 28, 2020

Conversation

csouchet
Copy link
Member

@csouchet csouchet commented Oct 26, 2020 •
edited
Loading

Covers #775

@csouchet csouchet added enhancement New feature or request depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first BPMN diagram usability Something about the way we can interact with BPMN diagrams labels Oct 26, 2020
@csouchet csouchet mentioned this pull request Oct 26, 2020
Merged
@csouchet csouchet force-pushed the 775-Vertical_fit_the_viewport_on_diagram_load branch 11 times, most recently from 668b100 to 605c0ac Compare October 27, 2020 15:55
@tbouffard tbouffard mentioned this pull request Oct 28, 2020
Closed
@csouchet csouchet force-pushed the 775-Vertical_fit_the_viewport_on_diagram_load branch 6 times, most recently from 5fe21f4 to bcc6145 Compare October 28, 2020 16:05
@csouchet csouchet force-pushed the 775-Vertical_fit_the_viewport_on_diagram_load branch from bcc6145 to 40c2856 Compare October 28, 2020 16:06
@csouchet csouchet removed the depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first label Oct 28, 2020
@csouchet csouchet marked this pull request as ready for review October 28, 2020 16:07
tbouffard
tbouffard approved these changes Oct 28, 2020
View reviewed changes
Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csouchet csouchet merged commit 196ba7a into master Oct 28, 2020
@csouchet csouchet deleted the 775-Vertical_fit_the_viewport_on_diagram_load branch October 28, 2020 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbouffard tbouffard tbouffard approved these changes

@aibcmars aibcmars Awaiting requested review from aibcmars

Assignees
No one assigned
Labels
BPMN diagram usability Something about the way we can interact with BPMN diagrams enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@csouchet @tbouffard