Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR] Use the diagram rendering html page on the visual tests for the fit margin on load #894

Merged
merged 1 commit into from
Nov 19, 2020

Conversation

csouchet
Copy link
Member

No description provided.

@csouchet csouchet added the refactoring Code refactoring label Nov 18, 2020
@csouchet csouchet marked this pull request as ready for review November 18, 2020 16:50
@csouchet csouchet force-pushed the refactor_diagram_rendering_visual_tests branch from 2a7e465 to 9557593 Compare November 19, 2020 13:53
@csouchet csouchet changed the title [REFACTOR] Use the diagram rendering html page fit the visual tests for the fit margin on load [REFACTOR] Use the diagram rendering html page on the visual tests for the fit margin on load Nov 19, 2020
Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • before: 135 tests
  • after: 135 tests
  • all diagram tests now use the page with the bpmn container that displays borders (helpful to better view fit and margin)

@csouchet csouchet merged commit 0dd5514 into master Nov 19, 2020
@csouchet csouchet deleted the refactor_diagram_rendering_visual_tests branch November 19, 2020 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Code refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants