Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hello P5: song example breaks the preview window #418

Closed
rasagy opened this issue Aug 24, 2017 · 2 comments
Closed

Hello P5: song example breaks the preview window #418

rasagy opened this issue Aug 24, 2017 · 2 comments

Comments

@rasagy
Copy link

rasagy commented Aug 24, 2017

What I tried to do

Opened the first Example in the list — Hello P5 : song, and clicked on play song automatically. Here’s the project: http://alpha.editor.p5js.org/p5/sketches/r1SLhBE4mZ-

What happened

The sketch played two notes, and then reloaded the page with editor inside the preview section:

image

Other attempts

I read on #414 (comment) that there are some errors with the Preview section that don’t show up on Full screen, so I went to Share, got the link as http://alpha.editor.p5js.org/full/r1SLhBE4mZ- and tried this in the full screen link.

  • First time, it played a note and appended a / to the link: http://alpha.editor.p5js.org/full/r1SLhBE4mZ-/#
  • After clicking on the play song automatically link, it appended another / to the link: http://alpha.editor.p5js.org/full/r1SLhBE4mZ-//# and gave a 404.
Here’s a gif and screenshot of the console

GIF:


p5 editor inception

Errors in console:

screenshot 2017-08-24 15 30 47

Errors in full screen view:

screenshot 2017-08-24 15 36 57

Platform details

I’m on Google Chrome Version 60.0.3112.101 (Official Build) (64-bit) / Mac Sierra.

Let me know in case this is already being discussed in another issue/you need more info to replicate it!

@catarak
Copy link
Member

catarak commented Aug 28, 2017

Thanks for the detailed breakdown! This is a known issue, discussed in #145. The example actually got fixed, I just need to rerun the task in production. I'll do that right now 😄

@catarak
Copy link
Member

catarak commented Aug 28, 2017

This is now fixed in production. Dom links still cause the editor to render in the iframe, so I will leave #145 open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants