Implemented loadXML() functionality #40 #1255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
@lmccart Since this is a new and needed feature are there any more changes in other files I would have to make for loadXML to work fully and conviniently? |
|
thanks @DarkPrince304 this is great!! i apologize it took so long to review. i just merged it in and made a few edits to the code and added examples for all methods. |
|
@lmccart no problem. I'm really happy to make this long awaited feature work. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have implemented most of the stuff discussed in #40 , though there are still somethings like saveXML(), etc left, which I would like to do after this.
There's just one problem which I would like to solve in this PR only before getting it merged.
Inside the .then() function I have tried to print the final XML Tree and it prints the output correctly but when I store it in the ret variable and then return it later on then it returns undefined. I would like some help on this so I can make a commit in this PR only.
@lmccart , @shiffman your views on this?