-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Commit
…hat cannot be displayed are automatically hidden. Removed old code which attempted to reduce tab size by hiding the text
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -273,7 +273,9 @@ public void paintComponent(Graphics screen) { | |
tab.textWidth = (int) | ||
font.getStringBounds(tab.text, g2.getFontRenderContext()).getWidth(); | ||
} | ||
|
||
/* TODO eliminated 279-302 because it doesn't really work to reduce the tab size (by much anyways) | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
pvrs12
Author
Contributor
|
||
* and makes it confusing to find the tab you want because the name is hidden | ||
* | ||
// make sure everything can fit | ||
if (!placeTabs(MARGIN_WIDTH, tabMax, null)) { | ||
//System.arraycopy(tabs, 0, visitOrder, 0, tabs.length); | ||
|
@@ -297,14 +299,19 @@ public void paintComponent(Graphics screen) { | |
break; | ||
} | ||
} | ||
} | ||
}*/ | ||
|
||
// now actually draw the tabs | ||
placeTabs(MARGIN_WIDTH, tabMax, g2); | ||
|
||
// draw the dropdown menu target | ||
menuLeft = tabs[tabs.length - 1].right + TAB_BETWEEN; | ||
menuRight = menuLeft + ARROW_TAB_WIDTH; | ||
if(!placeTabs(MARGIN_WIDTH, tabMax - ARROW_TAB_WIDTH, g2)){ | ||
// draw the dropdown menu target at the right of the window | ||
menuRight = tabMax; | ||
menuLeft = menuRight - ARROW_TAB_WIDTH; | ||
} else { | ||
// draw the dropdown menu target next to the tabs | ||
menuLeft = tabs[tabs.length - 1].right + TAB_BETWEEN; | ||
menuRight = menuLeft + ARROW_TAB_WIDTH; | ||
} | ||
|
||
g.setColor(tabColor[UNSELECTED]); | ||
drawTab(g, menuLeft, menuRight); | ||
// int arrowY = (getHeight() - TAB_HEIGHT - TAB_STRETCH) + (TAB_HEIGHT - ARROW_HEIGHT)/2; | ||
|
@@ -370,7 +377,7 @@ private boolean placeTabs(int left, int right, Graphics2D g) { | |
// } | ||
tab.right = x; | ||
|
||
if (g != null) { | ||
if (g != null && tab.right < right) { | ||
g.setColor(tabColor[state]); | ||
drawTab(g, tab.left, tab.right); | ||
// path.lineTo(x - NOTCH, top); | ||
|
Ugh, just found this. Please don't remove working code because you don't find it convenient or to your liking. This makes a mess for me to have to come back and sort it out. I wouldn't have accepted this patch had I noticed this before.