Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use include_lib() to import external libraries. #1446

Closed
wants to merge 1 commit into from

Conversation

bowlofeggs
Copy link
Contributor

This commit adjusts several include() statements across the project to use include_lib() instead so that the libraries can be found from a system install. This commit enables ejabberd-16.12 to be built in Fedora Rawhide with xmpp and fast_xml being installed in /usr/lib64/erlang/lib/.

If there's a better way to do this, I'd love to know about it (I'm new to Erlang)!

@bowlofeggs
Copy link
Contributor Author

See also processone/xmpp#3 where I had a similar problem when trying to build xmpp in Fedora Rawhide. (Please do educate me if there's a better way for me to get the build to find those includes!)

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.006%) to 36.042% when pulling 7b27887 on bowlofeggs:find_xmpp into f5290a8 on processone:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 36.101% when pulling af1a962 on bowlofeggs:find_xmpp into f5290a8 on processone:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 36.101% when pulling af1a962 on bowlofeggs:find_xmpp into f5290a8 on processone:master.

@p1bot
Copy link
Collaborator

p1bot commented Jan 21, 2019

Hi @bowlofeggs, many thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

@p1bot p1bot added cla-missing Contributor needs to sign Contribution License Agreement and removed Component:Build labels Jan 21, 2019
@bowlofeggs
Copy link
Contributor Author

I am not able to agree to the contributor license agreement. I do, however, agree to the DCO if that helps, since it does not grant my contribution under a different license than the project is granted under.

@mremond mremond closed this Jan 30, 2019
@bowlofeggs bowlofeggs deleted the find_xmpp branch February 6, 2019 20:16
@bowlofeggs
Copy link
Contributor Author

@mremond though I can't sign the agreement, I do think it's pretty reasonable to say that the change I proposed here is trivial enough that it wouldn't be a problem if someone else just did the same thing. I would like to see the change or an equivalent change go in. It's not like I invented time travel here ☺

@bowlofeggs
Copy link
Contributor Author

(otherwise I have to keep carrying this patch in Fedora, which isn't a huge problem, but I'd prefer if Fedora could stay as close to upstream as possible without having to maintain extra patches…)

@mremond
Copy link
Member

mremond commented Feb 7, 2019

@bowlofeggs Thanks !

And many thanks for your work on the Fedora package. We would love to be able to make it easier to build for distribution maintainers.

@lock
Copy link

lock bot commented Feb 8, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Feb 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-missing Contributor needs to sign Contribution License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants