-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use include_lib() to import external libraries. #1446
Conversation
See also processone/xmpp#3 where I had a similar problem when trying to build xmpp in Fedora Rawhide. (Please do educate me if there's a better way for me to get the build to find those includes!) |
1 similar comment
Hi @bowlofeggs, many thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. |
I am not able to agree to the contributor license agreement. I do, however, agree to the DCO if that helps, since it does not grant my contribution under a different license than the project is granted under. |
@mremond though I can't sign the agreement, I do think it's pretty reasonable to say that the change I proposed here is trivial enough that it wouldn't be a problem if someone else just did the same thing. I would like to see the change or an equivalent change go in. It's not like I invented time travel here ☺ |
(otherwise I have to keep carrying this patch in Fedora, which isn't a huge problem, but I'd prefer if Fedora could stay as close to upstream as possible without having to maintain extra patches…) |
@bowlofeggs Thanks ! And many thanks for your work on the Fedora package. We would love to be able to make it easier to build for distribution maintainers. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This commit adjusts several
include()
statements across the project to useinclude_lib()
instead so that the libraries can be found from a system install. This commit enables ejabberd-16.12 to be built in Fedora Rawhide withxmpp
andfast_xml
being installed in/usr/lib64/erlang/lib/
.If there's a better way to do this, I'd love to know about it (I'm new to Erlang)!