Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings #157

Merged
merged 4 commits into from
Jun 11, 2018
Merged

Fix warnings #157

merged 4 commits into from
Jun 11, 2018

Conversation

Randl
Copy link
Contributor

@Randl Randl commented Jun 4, 2018

Reduce entropy a bit

@leha-bot
Copy link
Member

leha-bot commented Jun 4, 2018

Thank you! Looks good for me. Does this commit fix "unused variable" warnings?

@leha-bot leha-bot added this to the Refactoring milestone Jun 4, 2018
@leha-bot leha-bot added category:Enhancement This is a proposed improvement category:Infrastructure Related to build tools, automation labels Jun 4, 2018
@Randl
Copy link
Contributor Author

Randl commented Jun 4, 2018 via email

@crackedmind
Copy link
Member

@crackedmind
Copy link
Member

@crackedmind
Copy link
Member

leha-bot
leha-bot previously approved these changes Jun 8, 2018
Copy link
Member

@leha-bot leha-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@crackedmind
Copy link
Member

@crackedmind
Copy link
Member

Copy link
Member

@leha-bot leha-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Splendid! It seems that fixes reduces the compilation time (it compiled on my linux vm for 16 mins)!

Almost all warnings are gone on my Fedora 28. Only deprecated warnings left. It's a ffmpeg issue, and I think we'll fix it in next PR.

Approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:Enhancement This is a proposed improvement category:Infrastructure Related to build tools, automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants