Skip to content

Commit

Permalink
Use actual example data
Browse files Browse the repository at this point in the history
  • Loading branch information
@erichuanggit
erichuanggit committed Sep 7, 2015
1 parent 21845e9 commit d090ab8
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions pdc/apps/compose/views.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1064,9 +1064,9 @@ def list(self, request):
[
{
"bugzilla_component": [
<string>
GConf1, GConf2
],
"bugzilla_product": <string>
"bugzilla_product": Fedora
},
...
]
Expand All @@ -1077,9 +1077,9 @@ def list(self, request):
[
{
"bugzilla_component": [
<string>
GConf1, GConf2
],
"bugzilla_product": <string>
"bugzilla_product": Fedora
}
]
"""
Expand Down

2 comments on commit d090ab8

@lubomir
Copy link
Member

@lubomir lubomir commented on d090ab8 Sep 7, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I probably did not express myself well. My remark was to only change the example. The response section should tell the user that bugzilla_component is a list of strings, but the example should show specific values. There is no point in showing the same JSON twice.

Also, since the example should show actual data, the values should be wrapped in double quotes so that it is valid JSON.

@erichuanggit
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad :-) Thanks

Please sign in to comment.