Error during writeout PQR file #1618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File ~/envs/prody/lib/python3.9/site-packages/prody/proteins/pdbfile.py:1620, in writePQRStream(stream, atoms, **kwargs) 1617 for item2 in sorted_sheet[i-num_strands:i]: 1618 item2.append(num_strands) -> 1620 num_strands = item[1] 1621 for item2 in sorted_sheet[i-num_strands+1:]: 1622 item2.append(num_strands) NameError: name 'item' is not defined
|
It does seem to, yes. It could have been that it was meant to be inside the loop though. |
|
I'm pretty sure this is actually right as the output files look how they should. Thanks very much for fixing it. |
|
I also spotted that the sheets shouldn't be sorted so I'll make a pull request to fix that once I've merged yours |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure but it works after modification