Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced deprecated jQuery functions #458

Merged
merged 3 commits into from
Jun 23, 2020
Merged

Conversation

bytestream
Copy link
Collaborator

Description

Replaces deprecated jQuery 3 functions listed at https://api.jquery.com/category/deprecated/

@@ -446,10 +446,14 @@ $.extend(true, laravelValidation, {
* @return {boolean}
*/
In: function(value, element, params) {
if ($.isArray(value) && laravelValidation.helpers.hasRules(element, "Array")) {
if (laravelValidation.helpers.isArray(value)
&& laravelValidation.helpers.hasRules(element, "Array")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Misleading line break before '&&'; readers may interpret this as an expression boundary.
Mixed double and single quotes.

errors[ element.name ] = previous.message = $.isFunction( message ) ? message( value ) : message[0];
errors[ element.name ]
= previous.message
= typeof message === "function" ? message( value ) : message[0];

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long.
Misleading line break before '='; readers may interpret this as an expression boundary.
Mixed double and single quotes.

@@ -224,7 +226,9 @@ laravelValidation = {
} else {
errors = {};
message = response || validator.defaultMessage( element, "remote" );
errors[ element.name ] = previous.message = $.isFunction( message ) ? message( value ) : message[0];
errors[ element.name ]
= previous.message

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Misleading line break before '='; readers may interpret this as an expression boundary.

errors[ element.name ] = previous.message = $.isFunction( message ) ? message( value ) : message;
errors[ element.name ]
= previous.message
= typeof message === "function" ? message( value ) : message;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long.
Misleading line break before '='; readers may interpret this as an expression boundary.
Mixed double and single quotes.

@@ -104,7 +104,9 @@ laravelValidation = {
validator.showErrors();
} else {
var errors = {};
errors[ element.name ] = previous.message = $.isFunction( message ) ? message( value ) : message;
errors[ element.name ]
= previous.message

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Misleading line break before '='; readers may interpret this as an expression boundary.

@bytestream bytestream merged commit a40ffc2 into proengsoft:master Jun 23, 2020
@bytestream bytestream deleted the #457 branch June 23, 2020 12:15
@bytestream bytestream linked an issue Jun 23, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jQuery deprecation notices
2 participants