Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profanity crashes when blocking a MUC participant #1156

Closed
mdosch opened this issue Jul 19, 2019 · 3 comments · Fixed by #1157
Closed

Profanity crashes when blocking a MUC participant #1156

mdosch opened this issue Jul 19, 2019 · 3 comments · Fixed by #1157
Assignees
Labels
Milestone

Comments

@mdosch
Copy link
Contributor

mdosch commented Jul 19, 2019

After blocking a MUC participant profanity crashes. See bt.

Expected Behavior

No crash.

Current Behavior

Profanity crashes with SIGABRT

Steps to Reproduce (for bugs)

Join a MUC (e.g. botkindergarten@conference.zombofant.net) and block a participant (e.g. /blocked add botkindergarten@conference.zombofant.net/feedbot)

Context

Environment

OS: Debian testing/sid (I was running sid during the freeze and am slowly going back to testing with some picks from sid)

profanity --version
Profanity, version 0.6.0dev.master.1bb05569
Copyright (C) 2012 - 2019 James Booth <boothj5web@gmail.com>.
Copyright (C) 2019 Michael Vetter <jubalh@iodoru.org>.
License GPLv3+: GNU GPL version 3 or later <https://www.gnu.org/licenses/gpl.html>

This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Build information:
XMPP library: libstrophe
Desktop notification support: Enabled
OTR support: Disabled
PGP support: Enabled (libgpgme 1.12.0)
OMEMO support: Enabled
C plugins: Enabled
Python plugins: Enabled (2.7.16)
GTK icons: Enabled
prosodyctl about

Prosody hg:a36c731ed540

# Prosody directories
Data directory:     /home/md85/var/lib/prosody
Config directory:   /home/md85/etc/prosody
Source directory:   /home/md85/lib/prosody
Plugin directories:
  /home/md85/opt/prosody-modules/
  /home/md85/lib/prosody/modules/
  

# Operating system
Linux 2.6.32-754.15.3.el6.x86_64	

# Lua environment
Lua version:             	Lua 5.2

Lua module search paths:
  /home/md85/lib/prosody/?.lua
  /home/md85/.luarocks/share/lua/5.2/?.lua
  /home/md85/.luarocks/share/lua/5.2/?/init.lua
  /home/md85/share/lua/5.2/?.lua
  /home/md85/share/lua/5.2/?/init.lua

Lua C module search paths:
  /home/md85/lib/prosody/?.so
  /home/md85/.luarocks/lib/lua/5.2/?.so
  /home/md85/lib/lua/5.2/?.so

LuaRocks:        	Installed (2.4.3)

# Network

Backend: epoll

# Lua module versions
lfs:     	LuaFileSystem 1.7.0
libevent:	2.1.8-stable
luaevent:	0.4.6
lxp:     	LuaExpat 1.3.3
socket:  	LuaSocket 3.0-rc1
ssl:     	0.8
@jubalh
Copy link
Member

jubalh commented Jul 19, 2019

My guess is that this has the same root cause as #1151
And has to do with freed handlers.

@jubalh jubalh added the bug label Jul 19, 2019
@jubalh jubalh modified the milestones: 0.8.0, 0.6.0, 0.7.0 Jul 19, 2019
jubalh added a commit that referenced this issue Jul 19, 2019
Another case of double free() due to new destructor.

Fixes #1156
@jubalh jubalh self-assigned this Jul 19, 2019
@mdosch
Copy link
Contributor Author

mdosch commented Jul 19, 2019

Blocking and unblocking works now, but #1151 is not yet fixed (as you considered this related).

@mdosch mdosch closed this as completed Jul 19, 2019
@jubalh
Copy link
Member

jubalh commented Jul 19, 2019

Thanks! Yes, that's expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants