Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for XEP-0045 7.10 "Registering with a room" #1210

Closed
mdosch opened this issue Oct 21, 2019 · 4 comments
Closed

Add support for XEP-0045 7.10 "Registering with a room" #1210

mdosch opened this issue Oct 21, 2019 · 4 comments
Assignees
Labels
Milestone

Comments

@mdosch
Copy link
Contributor

mdosch commented Oct 21, 2019

I'd appreciate if profanity could register my nickname in a MUC to prevent others to occupy my nick while I am offline. This is defined in XEP-0045 7.10.

I have successfully registered a nick at MUCs where I have "member" state hosted prosody 0.11.x servers. I didn't manage to do so with MUCs on ejabberd yet, but maybe @weiss could clarify if these procedure should also work for ejabberd.

This is an example for my successful request in one MUC:

<iq type="get" to="kuketzblog@rooms.dismail.de" id="register0815-1"> <query xmlns="http://jabber.org/protocol/disco#info"/></iq>
21/10/2019 19:45:53: xmpp: DBG: RECV: <iq id="register0815-1" to="REDACTED/KI29sWXY" lang="en" type="result" from="kuketzblog@rooms.dismail.de"><query xmlns="http://jabber.org/protocol/disco#info" node=""><feature var="muc_open"/><feature var="muc_unsecured"/><feature var="http://jabber.org/protocol/muc"/><feature var="http://jabber.org/protocol/muc#stable_id"/><feature var="http://jabber.org/protocol/muc#self-ping-optimization"/><feature var="muc_public"/><feature var="muc_persistent"/><feature var="http://jabber.org/protocol/muc#request"/><feature var="vcard-temp"/><feature var="muc_moderated"/><identity type="text" category="conference" name="Kuketz-Blog"/><feature var="urn:xmpp:mam:2"/><feature var="jabber:iq:register"/><feature var="muc_semianonymous"/><x xmlns="jabber:x:data" type="result"><field type="hidden" var="FORM_TYPE"><value>http://jabber.org/protocol/muc#roominfo</value></field><field label="Allow members to invite new members" type="boolean" var="{http://prosody.im/protocol/muc}roomconfig_allowmemberinvites"><value>0</value></field><field type="boolean" var="muc#roominfo_changesubject"/><field label="Number of occupants" type="text-single" var="muc#roominfo_occupants"><value>396</value></field><field type="text-single" var="{http://modules.prosody.im/mod_vcard_muc}avatar#sha1"><value>f9db3899f4532402b70c22aa9c7a343f38a41728</value></field><field label="Title" type="text-single" var="muc#roomconfig_roomname"><value>Kuketz-Blog</value></field><field type="text-single" var="muc#roominfo_lang"><value>de</value></field><field label="Description" type="text-single" var="muc#roominfo_description"><value>IT-Sicherheit | Datenschutz | Hacking -  Weitere Infos: https://www.kuketz-blog.de/chat/</value></field></x></query></iq>
<iq type="get" to="kuketzblog@rooms.dismail.de" id="register0815-2"> <query xmlns="jabber:iq:register"/></iq>
21/10/2019 19:46:17: xmpp: DBG: RECV: <iq id="register0815-2" to="REDACTED/KI29sWXY" lang="en" type="result" from="kuketzblog@rooms.dismail.de"><query xmlns="jabber:iq:register"><registered/><username>Martin</username></query></iq>
<iq type="set" to="kuketzblog@rooms.dismail.de" id="register0815-3"> <query xmlns="jabber:iq:register">  <x xmlns="jabber:x:data" type="submit">   <field type="text-single" var="muc#register_roomnick">    <value>Martin</value>   </field>  </x> </query></iq>
21/10/2019 19:46:38: xmpp: DBG: RECV: <iq id="register0815-3" to="REDACTED/KI29sWXY" lang="en" type="result" from="kuketzblog@rooms.dismail.de"/>
@jubalh
Copy link
Member

jubalh commented Oct 22, 2019

Thanks for the request. Makes sense to have this.
I'll close this until we are down to 50 ;)
Feel free to reopen then.

@jubalh jubalh closed this as completed Oct 22, 2019
@jubalh jubalh reopened this Dec 23, 2019
@jubalh jubalh removed the defer label Dec 23, 2019
@jubalh jubalh added this to the 0.9.0 milestone Jan 30, 2020
@jubalh jubalh modified the milestones: 0.9.0, 0.10.0 Jun 3, 2020
@weiss
Copy link
Contributor

weiss commented Dec 21, 2020

if these procedure should also work for ejabberd.

It won't; ejabberd allows for registering a nickname with the entire MUC service (conference.example.com), but not per-room (room@conference.example.com). However, the procedure you outlined above is the one documented in XEP-0045, so I guess it would be better to implement that in ejabberd than to add support for ejabberd's old mechanism to new clients.

@jubalh jubalh modified the milestones: 0.10.0, 0.11.0 Jan 9, 2021
@jubalh jubalh self-assigned this Mar 19, 2021
jubalh added a commit that referenced this issue Mar 21, 2021
`/affiliation register` can now be used to register a nickname with a
MUC.

Implements #1210
jubalh added a commit that referenced this issue Mar 25, 2021
`/affiliation register` can now be used to register a nickname with a
MUC.

Tested with a server without forms. Couldn't find a server which
supports forms yet.

Implements #1210
@licaon-kter
Copy link
Contributor

@weiss this wasn't yet pursued, right?

jubalh added a commit that referenced this issue Mar 25, 2021
`/affiliation register` can now be used to register a nickname with a
MUC.

Tested with a server without forms. Couldn't find a server which
supports forms yet.

Implements #1210
@jubalh jubalh closed this as completed Mar 25, 2021
@mdosch
Copy link
Contributor Author

mdosch commented Mar 25, 2021

@licaon-kter See the referenced ejabberd issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants