Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing room title does not take effect until the next session #1710

Closed
MarcoPolo-PasTonMolo opened this issue May 15, 2022 · 1 comment · Fixed by #1711
Closed

Changing room title does not take effect until the next session #1710

MarcoPolo-PasTonMolo opened this issue May 15, 2022 · 1 comment · Fixed by #1711
Assignees
Milestone

Comments

@MarcoPolo-PasTonMolo
Copy link
Collaborator

When I change the name of a room with /room config the old name remains in the roster and titlebar. It does however change in other clients or if I disconnect and connect again.

Expected Behavior

Room name changes after /form submit in the titlebar and roster

Current Behavior

Room name does not change until next session.

Steps to Reproduce (for bugs)

  1. Creat room, give it a title
  2. Run /room config
  3. Change title with /field1 new-title
  4. /form submit
  5. Observe the titlebar having the old name

Context

Tried to change room name but wasn't sure if it worked

Environment

Profanity, version 0.12.1dev.master.0293b639
Copyright (C) 2012 - 2019 James Booth <boothj5web@gmail.com>.
Copyright (C) 2019 - 2021 Michael Vetter <jubalh@iodoru.org>.
License GPLv3+: GNU GPL version 3 or later <https://www.gnu.org/licenses/gpl.html>

This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Build information:
XMPP library: libstrophe
Desktop notification support: Enabled
OTR support: Enabled (libotr 4.1.1)
PGP support: Enabled (libgpgme 1.17.1)
OMEMO support: Enabled
C plugins: Enabled
Python plugins: Enabled (3.10.4)
GTK icons/clipboard: Enabled
@MarcoPolo-PasTonMolo
Copy link
Collaborator Author

Also if the room name changes from another client in profanity the old one remains until the next session

MarcoPolo-PasTonMolo added a commit to MarcoPolo-PasTonMolo/profanity that referenced this issue May 18, 2022
Now whenever the name of a room changes, either in profanity or another
client, it gets updated inside profanity.
Fixes profanity-im#1710
MarcoPolo-PasTonMolo added a commit to MarcoPolo-PasTonMolo/profanity that referenced this issue May 18, 2022
Now whenever the name of a room changes, either in profanity or another
client, it gets updated inside profanity.
Fixes profanity-im#1710
@jubalh jubalh added this to the 0.13.0 milestone May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants