Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/url save Autocompletion doesn't autocomplete filenames #1783

Closed
MarcoPolo-PasTonMolo opened this issue Dec 18, 2022 · 0 comments · Fixed by #1784
Closed

/url save Autocompletion doesn't autocomplete filenames #1783

MarcoPolo-PasTonMolo opened this issue Dec 18, 2022 · 0 comments · Fixed by #1784
Assignees
@MarcoPolo-PasTonMolo
Labels
bug
Milestone
0.14.0

Comments

@MarcoPolo-PasTonMolo
Copy link
Collaborator

/url save doesn't autocomplete filenames it only autocompletes the url. If I press tab while writing some filename the filename gets deleted and the link gets replaced by the next link in ac.

Expected Behavior

/url save should autocomplete the url as it does now but after that is typed and a space is inserted it should autocomplete filenames/paths

Current Behavior

/url save autocompletes only the url, anything else typed after gets deleted and the next url is shown

Possible Solution

Steps to Reproduce (for bugs)

  1. Get url in your chat window
  2. Type /url save press tab to get the url now start typing a location to save to, press tab
  3. Observe

Context

Makes /url save inconvenient to use.

Environment

Profanity, version 0.13.1dev.fix/segfault-mam.135a4cd9
Copyright (C) 2012 - 2019 James Booth boothj5web@gmail.com.
Copyright (C) 2019 - 2022 Michael Vetter jubalh@iodoru.org.
License GPLv3+: GNU GPL version 3 or later https://www.gnu.org/licenses/gpl.html

This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Build information:
XMPP library: libstrophe
Desktop notification support: Enabled
OTR support: Enabled (libotr 4.1.1)
PGP support: Enabled (libgpgme 1.18.0)
OMEMO support: Enabled
C plugins: Enabled
Python plugins: Enabled (3.10.8)
GTK icons/clipboard: Enabled
GDK Pixbuf: Enabled
@MarcoPolo-PasTonMolo MarcoPolo-PasTonMolo changed the title /url save Autocompletion doesn't autocomplete filenames /url save Autocompletion doesn't autocomplete filenames Dec 18, 2022
@jubalh jubalh added this to the next milestone Dec 18, 2022
@jubalh jubalh added the bug label Dec 18, 2022
MarcoPolo-PasTonMolo added a commit to MarcoPolo-PasTonMolo/profanity that referenced this issue Dec 24, 2022
@MarcoPolo-PasTonMolo
Make /url save autocomplete filenames after a url
5ddf14b 
Previously after the url if you pressed tab, even if you typed out a
filepath, profanity would erase that and cycle through url autocomplete
results.

This patch solves that and autocompletes filepaths after the url.

Fixes profanity-im#1783
Merged
MarcoPolo-PasTonMolo added a commit to MarcoPolo-PasTonMolo/profanity that referenced this issue Dec 27, 2022
@MarcoPolo-PasTonMolo
Make /url save autocomplete filenames after a url
525ec11 
Previously after the url if you pressed tab, even if you typed out a
filepath, profanity would erase that and cycle through url autocomplete
results.

This patch solves that and autocompletes filepaths after the url.

Fixes profanity-im#1783
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarcoPolo-PasTonMolo MarcoPolo-PasTonMolo

Labels
bug
Projects
None yet
Milestone
0.14.0
Development

Successfully merging a pull request may close this issue.

Make /url save autocomplete filenames after a url MarcoPolo-PasTonMolo/profanity
2 participants
@jubalh @MarcoPolo-PasTonMolo