Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better UI behaviour in MUC windows when connection re-established #704

Closed
boothj5 opened this issue Jan 5, 2016 · 1 comment
Closed

Better UI behaviour in MUC windows when connection re-established #704

boothj5 opened this issue Jan 5, 2016 · 1 comment
Assignees
@jubalh
Labels
improvement medium
Milestone
0.7.0

Comments

@boothj5
Copy link
Collaborator

boothj5 commented Jan 5, 2016

Currently when the connection is lost the following is displayed in any open MUC windows:

Lost connection

If and when the connection is re-established, the room history is shown again which messes up the flow of messages.

Change this behaviour to not show the room history but instead something like:

Connection re-established
@boothj5 boothj5 added this to the 0.5.0 milestone Jan 5, 2016
@boothj5 boothj5 modified the milestones: 0.5.1, 0.5.0 Feb 3, 2016
@boothj5 boothj5 modified the milestones: 0.6.0, 0.5.1 Sep 25, 2016
@jubalh jubalh modified the milestones: 0.6.0, 0.7.0 Jan 8, 2019
@jubalh jubalh mentioned this issue Jun 4, 2019
Merged
@jubalh jubalh self-assigned this Jun 5, 2019
jubalh added a commit that referenced this issue Jun 5, 2019
@jubalh
Only print room history for new messages upon reconnect
13675fb 
If re-establish a connection don't print the room history again.
In case there there happened nothing at all since we got the room
history on the last connection.
And in case there were no new messages during the time we have been
disconnected.

Instead of printing the room history again we now print 'Re-established
Connection'.

This adds a bit of overhead since we save the timestamp upon every MUC
message.

See: #704
jubalh added a commit that referenced this issue Jun 5, 2019
@jubalh
Only show MUC subject on first connect
ce5a4ed 
For #704 we don't show the room history upon reconnect.
Now we also don't show the room subject in the channel
upon re-established connection.
@jubalh
Copy link
Member

jubalh commented Jun 11, 2019

Closed by #1110

@jubalh jubalh closed this as completed Jun 11, 2019
@jubalh jubalh mentioned this issue Jun 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jubalh jubalh

Labels
improvement medium
Projects
None yet
Milestone
0.7.0
Development

No branches or pull requests
2 participants
@boothj5 @jubalh