Add meson build system support #1619
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can only build minimal profanity without optional dependencies yet. Not all functionality from autoconf is in here yet.
eli-schwartz
reviewed
Dec 1, 2021
* Used the wrong define BUILD_PGP instead of HAVE_LIBGPGME * Need to add the sources conditionally
eli-schwartz
reviewed
Dec 1, 2021
eli-schwartz
reviewed
Dec 1, 2021
We need to add the header files to the include dir conditionally too.
According to @eli-schwartz review #1619 (comment): ``` "notifications" is a feature object. When configured with -Dnotifications=disabled it logs: Dependency libnotify skipped: feature notifications disabled [...] notifications : disabled and builds without support. pgp is a boolean option, which IMHO it shouldn't be. When configured with -Dpgp=false it logs: Run-time dependency gpgme found: YES 1.16.0 [...] pgp : false which is contradictory and misleading, because it was available and detected, just not required. So it tries to build with PGP support. BUILD_PGP is the Makefile.am define, not the C define. This should set HAVE_LIBGPGME. Later, in core_sources_c, check if pgp_dep.found() and add 'src/pgp/gpg.c' as an additional source. ```
eli-schwartz
reviewed
Dec 1, 2021
eli-schwartz
reviewed
Dec 1, 2021
|
After some internal discussions we decided to stay with autotools for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not yet decided whether we will switch to meson or support both autotools and meson.
Even when switching we will support both systems for some releases so that packagers have time to adjust and we can slowly iron out the meson build files.
Run:
meson buildormeson setup --wipe buildFollowed by
ninja -C buildorcd build && ninja.Take a look at meson_options.txt for the various flags. Enable/disable them with
meson build -Domemo=disabled.