This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
fix mr merge failing on detached branch
#743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`mr merge` fails with error `could not determine current branch: git: not on any branch` when run on a detached branch. This is due to glab fetching the current branch first before checking if a merge request ID was provided as argument.
Codecov Report
@@ Coverage Diff @@
## trunk #743 +/- ##
==========================================
+ Coverage 58.60% 58.61% +0.01%
==========================================
Files 93 93
Lines 6663 6665 +2
==========================================
+ Hits 3905 3907 +2
Misses 2379 2379
Partials 379 379
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mr mergefails with errorcould not determine current branch: git: not on any branchwhen run on a detached branch.This is due to glab fetching the current branch first before checking if a merge request ID was provided as argument.
Resolves #735