Skip to content
This repository has been archived by the owner on Nov 22, 2022. It is now read-only.

fix hostname validator to accept IPs and hosts with port #744

Merged
merged 2 commits into from
May 27, 2021

Conversation

profclems
Copy link
Owner

Resolves #738

@codecov
Copy link

codecov bot commented May 27, 2021

Codecov Report

Merging #744 (659108f) into trunk (cd37ff9) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            trunk     #744      +/-   ##
==========================================
+ Coverage   58.60%   58.63%   +0.02%     
==========================================
  Files          93       93              
  Lines        6663     6704      +41     
==========================================
+ Hits         3905     3931      +26     
- Misses       2379     2394      +15     
  Partials      379      379              
Impacted Files Coverage Δ
commands/auth/login/login.go 40.00% <100.00%> (ø)
commands/mr/mrutils/mrutils.go 65.46% <0.00%> (-0.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd37ff9...659108f. Read the comment docs.

@profclems profclems merged commit 48f6b60 into trunk May 27, 2021
@profclems profclems deleted the fix-hostname-validator branch May 27, 2021 22:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using different GitLab server Port
1 participant