Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Durations in Fs2RabbitConfig #474

Closed
DStranger opened this issue Feb 4, 2021 · 1 comment
Closed

Durations in Fs2RabbitConfig #474

DStranger opened this issue Feb 4, 2021 · 1 comment

Comments

@DStranger
Copy link

Hi guys!

Fs2RabbitConfig currently uses ints for durations, which is confusing:
connectionTimeout is defined in milliseconds,
requestedHeartbeat is defined in seconds.

Moreover, official examples use a very low value for connectionTimeout (3), which causes issues when being used in real environments, and adds to the confusion.

This can be solved in multiple ways, but I think the best solution would be to be able to specify durations as such (10 s, etc).
This would introduce some backward compatibility problems, so I'm curious what you think.

@jbwheatley
Copy link
Contributor

fixed in 4.0.0 (requires cats-effect 3)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants