Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature : Client-Provided Connection Name #698

Closed
tyrcho opened this issue Feb 21, 2022 · 4 comments
Closed

Feature : Client-Provided Connection Name #698

tyrcho opened this issue Feb 21, 2022 · 4 comments
Labels

Comments

@tyrcho
Copy link

tyrcho commented Feb 21, 2022

It would be a nice addition to support Client-Provided Connection Name to make investigating on AMQP server easier when a lot of connections are done on the same server.

I think this line would need to change : https://github.com/profunktor/fs2-rabbit/blob/master/core/src/main/scala/dev/profunktor/fs2rabbit/algebra/Connection.scala#L92

And I would suggest to add an extra argument in https://github.com/profunktor/fs2-rabbit/blob/master/core/src/main/scala/dev/profunktor/fs2rabbit/config/Fs2RabbitConfig.scala clientProvidedName: Option[String]

@tyrcho tyrcho changed the title Feature : name connections Feature : Client-Provided Connection Name Feb 21, 2022
@jbwheatley
Copy link
Contributor

@tyrcho would you have any interest in opening a PR? We have another one open that would warrant a major version bump, and we could put this change in with that :)

@tyrcho
Copy link
Author

tyrcho commented Mar 2, 2022

I don't have the time to do this, but I'll ask someone of my team, maybe he could manage that. Thanks for the support !

@tyrcho
Copy link
Author

tyrcho commented Mar 7, 2022

I think the MR was done by Paul here : #702

@stale
Copy link

stale bot commented May 31, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label May 31, 2022
@tyrcho tyrcho closed this as completed May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants