Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uninformative Error Messages #10

Closed
program-- opened this issue Jan 12, 2022 · 1 comment · Fixed by #14
Closed

Uninformative Error Messages #10

program-- opened this issue Jan 12, 2022 · 1 comment · Fixed by #14
Labels
bug Something isn't working

Comments

@program--
Copy link
Owner

fipio::as_fips(state = "FAKE")                                                                                                                                                            
#> Error in x[is.na(x)] <- y[!is.na(y)] : replacement has length zero

When as_fips() can't find any data, an error should be returned, but it should be informative.

@program-- program-- added the bug Something isn't working label Jan 12, 2022
@program--
Copy link
Owner Author

I'm making the decision that instead of throwing an error, fipio::as_fips() will return NA, so that its vectorization isn't impacted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant