gen: Improve identifier naming, quality of generated code

[tmc]

Fixes #119, this omits trailing underscores from generated identifiers and adopts new more Go-idiomatic naming.

[tmc]

This greatly improves the ergonomicsd of the generated code and godoc.

compare

with

[progrium]

Looks good so far. Much nicer. Don't know if people actually want lowercase class methods after underscore, but given we convert method names everywhere else to capitalized it seems like they should be capitalized too, even if they technically don't have to be. Thoughts?

[tmc]

Looks good so far. Much nicer. Don't know if people actually want lowercase class methods after underscore, but given we convert method names everywhere else to capitalized it seems like they should be capitalized too, even if they technically don't have to be. Thoughts?

Open to that, trying to do this iteratively and I think this merits inclusion as-is while we iterate on naming scheme.

[mgood]

IIRC the trailing underscores is something I saw done in PyObjC. I know it looks a little weird, but without it I think there can be selector conflicts where you have one with and one without an argument.

[tmc]

IIRC the trailing underscores is something I saw done in PyObjC. I know it looks a little weird, but without it I think there can be selector conflicts where you have one with and one without an argument.

Yeah we have an example in/with the webkit reload method

[progrium]

Looks good. Fairly breaking change though. Should we cut a release before merging?

[programmingkidx]

@progrium As for the question of whether to capitalize the first letter of a method's name when dealing with a class method. Objective-C doesn't do it. Go does like camel case. But Go functions don't usually have an underscore to them. If I had to vote between these options:

• NSEvent_alloc()
• NSEvent_Alloc()
• NSEventAlloc()

I would probably pick NSEvent_alloc(). It seems like less work to have to write it out like this.

As for cutting a release, please do so. The more release numbers there are the easier it to tell what changes have been made between releases.

[programmingkidx]

@tmc Thank you for the changes. I really like how the return type of a function is on the same line as the func statement. This is so much easier to read than how it was before.

[tmc]

we're doing NSEvent_Alloc for consistency

[programmingkidx]

@tmc I can learn to live with that.