Proposal zeroconf #162
Merged
Proposal zeroconf #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DazWilkin
requested review from
bfjelds,
Britel,
jiria and
kate-goldenring
as code owners
|
Thank you for reviewing @kate-goldenring! I'm headed to the dog park with my pupster, I'll incorporate your feedback tomorrow morning. |
|
@kate-goldenring Thanks for the feedback.... I think I've incorporated everything. |
kate-goldenring
added
the
documentation
bfjelds
reviewed
Dec 9, 2020
|
|
||
| ## Outstanding Questions | ||
|
|
||
| + What would a generic Akri Zeroconf Broker do? In practice, the application developer would likely wish to implement the Broker for their specific application. |
There was a problem hiding this comment.
this is not unlike udev. we don't provide a generic udev broker, but have a udev video broker. perhaps a similar approach can be applied here?
bfjelds
approved these changes
Dec 9, 2020
kate-goldenring
approved these changes
Dec 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Proposal per #132 (comment)
Special notes for your reviewer:
If applicable:
cargo fmt)cargo build)cargo clippy)cargo test)cargo doc)./version.sh)