Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nicolas Belouin (@diconico07) to CODEOWNERS #600

Merged

Conversation

diconico07
Copy link
Contributor

What this PR does / why we need it:
Add myself (Nicolas Belouin) as maintainer for akri.

Special notes for your reviewer:
This requires giving write access to the repository before merge

If applicable:

  • this PR has an associated PR with documentation in akri-docs
  • this PR contains unit tests
  • added code adheres to standard Rust formatting (cargo fmt)
  • code builds properly (cargo build)
  • code is free of common mistakes (cargo clippy)
  • all Akri tests succeed (cargo test)
  • inline documentation builds (cargo doc)
  • all commits pass the DCO bot check by being signed off -- see the failing DCO check for instructions on how to retroactively sign commits

Copy link
Contributor

@kate-goldenring kate-goldenring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the contributions you've already made @diconico07! Excited for you to join the maintainer team! 🥳

Copy link
Collaborator

@adithyaj adithyaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome aboard!😄

@kate-goldenring
Copy link
Contributor

@diconico07 can you merge/rebase and then we can officially merge 🎉

Signed-off-by: Nicolas Belouin <nicolas.belouin@suse.com>
@diconico07 diconico07 force-pushed the add-nicolas-belouin-codeowner branch from 2b3bf46 to 79cd77d Compare May 11, 2023 06:58
@kate-goldenring kate-goldenring merged commit 19e80e2 into project-akri:main May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants