-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generic udev Configuration #87
Generic udev Configuration #87
Conversation
I think it would make sense at this point to remove the udevVideo configuration. Instead in the udev video sample documentation, we can walk through the steps of setting the environment variables (udev values would need to modified to be able to configure this), broker image, and Configuration name. Thoughts? |
I wonder if we should phase out the udevVideo configuration, since it is part of our e2e demo. Some people may be currently running it. I could change the e2e to use just udev and then maybe we remove udevVideo entirely for our next release. That bodes the question: do be make onvifVideo onvif? |
165e4df
to
ab8e933
Compare
* add generic udev configuration and documentation * wrap text at 120 chars * make service deployment and env vars configurable and more docs * make generic onvif configuration and associated docs * specify use of development Helm chart * increase version * explain instance naming * update version.sh to check the new Configuration templates * explain broker image and grammatical fixes
What this PR does / why we need it:
We currently only have documentation and a sample Configuration for how to use the udev discovery handler to discover usb cameras. This adds a generic sample udev Configuration and documentation on how to use it to find any device discoverable by udev. It also modifies the name of the ONVIF configuration from onvif-video to onvif. This pr creates a standard of providing a generic configuration for each protocol that can be applied to a cluster with helm via
--set <protocol>-enabled=true
. Additionally, it sets the standard that a broker image must be specified on installation, else Akri will advertise the resources but not deploy brokers. Finally, it creates a standard of creating a<protocol>-configuration.md
document for each generic configuration provided.Special notes for your reviewer:
We've received questions on how to use udev to discover audio devices (ref #33). Modifying the udevVideo configuration seems illogical and starting from an empty yaml is a big barrier to entry.
closes #68
ref #69
If applicable:
cargo fmt
)cargo build
)cargo clippy
)cargo test
)cargo doc
)./version.sh
)