Skip to content
This repository has been archived by the owner on Apr 10, 2023. It is now read-only.

Change the way genres are displayed #20

Closed
knjk04 opened this issue May 15, 2020 · 2 comments · Fixed by #27
Closed

Change the way genres are displayed #20

knjk04 opened this issue May 15, 2020 · 2 comments · Fixed by #27
Assignees
Labels
enhancement New feature or improvement of an existing feature request good first issue Good for newcomers

Comments

@knjk04
Copy link
Member

knjk04 commented May 15, 2020

Is your feature request related to a problem? If so, please describe.
It's strange to see the genre in uppercase and for there to be underscores (as in the enum) in the new book form and the shelf grid.

Describe the solution you'd like

  • Every genre to be displayed in lower case
  • Spaces, not underscores, between words

For example, SCIENCE_FICTION should be Science fiction and, as a special case, NON_FICTION should be Non-fiction.

Additional context
Screenshot:
genres

@knjk04 knjk04 added enhancement New feature or improvement of an existing feature request good first issue Good for newcomers labels May 15, 2020
@tmrd993
Copy link
Contributor

tmrd993 commented May 15, 2020

I created a pull request for this

#27

@knjk04
Copy link
Member Author

knjk04 commented May 16, 2020

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or improvement of an existing feature request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants