-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faster chip-tool builds. #11699
Merged
woody-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:faster-chip-tool-build
Nov 11, 2021
Merged
Faster chip-tool builds. #11699
woody-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:faster-chip-tool-build
Nov 11, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses simpler templates for command sending to improve build times.
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
erjiaqing,
franck-apple,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
pan-apple and
sagar-apple
November 11, 2021 21:17
pullapprove
bot
requested review from
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
vivien-apple,
wbschiller and
woody-apple
November 11, 2021 21:17
PR #11699: Size comparison from 4374a54 to 40d210c Increases above 0.2%:
Increases (2 builds for linux)
Decreases (2 builds for linux)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
woody-apple
approved these changes
Nov 11, 2021
Fast tracking, given this improves builds. |
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Dec 2, 2021
This was missed in project-chip#11699
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this pull request
Dec 3, 2021
Uses simpler templates for command sending to improve build times.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses simpler templates for command sending to improve build times.
Problem
Compiling the explicit instantiations in CHIPClustersInvoke.cpp still takes a while (~45 seconds on my hardware, for a ~60 seconds overall build). It's not needed on every chip-tool build, but often enough.
Change overview
Switch to using a simplified invoke mechanism for chip-tool, with fewer layers of callbacks. This compiles in ~10-15 seconds, giving me a from-scratch chip-tool build in ~25 seconds.
Testing
No behavior changes; just changes how we thread the values through the code.