Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the Darwin per-step YAML timeouts larger and configurable. #14368

Merged
merged 1 commit into from
Jan 27, 2022
Merged

Make the Darwin per-step YAML timeouts larger and configurable. #14368

merged 1 commit into from
Jan 27, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

This makes the following changes:

  1. Bumps kTimeoutInSeconds from 3 to 5.
  2. For "WaitForMs" commands, sets the timeout to
    (waitTime/1000) + kTimeoutInSeconds, so longish waits work automatically.
  3. Allows specifying a "stepTimeoutSecs" property in the YAML to override
    all of that and just set a value.

Fixes #14364
Fixes #14260

Problem

Per-step 3s timeout is too short.

Change overview

See above.

Testing

Will see how CI runs. Tested manually that stepTimeoutSecs works in terms of the codegen.

@bzbarsky-apple
Make the Darwin per-step YAML timeouts larger and configurable.
4834ca4 
This makes the following changes:

1) Bumps kTimeoutInSeconds from 3 to 5.
2) For "WaitForMs" commands, sets the timeout to
   (waitTime/1000) + kTimeoutInSeconds, so longish waits work automatically.
3) Allows specifying a "stepTimeoutSecs" property in the YAML to override
   all of that and just set a value.

Fixes project-chip#14364
Fixes project-chip#14260
@boring-cyborg boring-cyborg bot added the darwin label Jan 26, 2022
@github-actions
Copy link

github-actions bot commented Jan 27, 2022 •
edited
Loading

PR #14368: Size comparison from ebff533 to 4834ca4

Full report (32 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section ebff533 4834ca4 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 580330 580330 0 0.0
.app_xip_area 485224 485224 0 0.0
.bss 77852 77852 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 843316 843316 0 0.0
(read/write) 127396 127396 0 0.0
.bss 125496 125496 0 0.0
.data 1900 1900 0 0.0
.text 843308 843308 0 0.0
BRD4161A+rpc (read only) 830672 830672 0 0.0
(read/write) 144056 144056 0 0.0
.bss 142056 142056 0 0.0
.data 2000 2000 0 0.0
.text 830664 830664 0 0.0
window-app BRD4161A (read only) 815948 815948 0 0.0
(read/write) 126052 126052 0 0.0
.bss 124196 124196 0 0.0
.data 1856 1856 0 0.0
.text 815940 815940 0 0.0
esp32 all-clusters-app c3devkit (read only) 921116 921116 0 0.0
(read/write) 1384722 1384722 0 0.0
.dram0.bss 70872 70872 0 0.0
.dram0.data 14244 14244 0 0.0
.flash.rodata 180672 180672 0 0.0
.flash.text 921116 921116 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 970111 970111 0 0.0
(read/write) 451744 451744 0 0.0
.dram0.bss 75616 75616 0 0.0
.dram0.data 34032 34032 0 0.0
.flash.rodata 209968 209968 0 0.0
.flash.text 964727 964727 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 665192 665192 0 0.0
.bss 77628 77628 0 0.0
.data 1868 1868 0 0.0
.text 579896 579896 0 0.0
lock k32w061+release (read/write) 666080 666080 0 0.0
.bss 77892 77892 0 0.0
.data 1892 1892 0 0.0
.text 580496 580496 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8900684 8900684 0 0.0
(read/write) 393505 393505 0 0.0
.bss 55377 55377 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 263528 263528 0 0.0
.dynamic 560 560 0 0.0
.got 69712 69712 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 542836 542836 0 0.0
.text 7511252 7511252 0 0.0
thermostat-no-ble arm64 (read only) 2061828 2061828 0 0.0
(read/write) 148113 148113 0 0.0
.bss 66417 66417 0 0.0
.data 904 904 0 0.0
.data.rel.ro 73712 73712 0 0.0
.dynamic 560 560 0 0.0
.got 4128 4128 0 0.0
.init 24 24 0 0.0
.init_array 320 320 0 0.0
.rodata 131428 131428 0 0.0
.text 1714416 1714416 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2355056 2355056 0 0.0
.bss 189580 189580 0 0.0
.data 5296 5296 0 0.0
.text 1317656 1317656 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2341048 2341048 0 0.0
.bss 181104 181104 0 0.0
.data 5584 5584 0 0.0
.text 1303648 1303648 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2307792 2307792 0 0.0
.bss 181000 181000 0 0.0
.data 5568 5568 0 0.0
.text 1270392 1270392 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2294060 2294060 0 0.0
.bss 177732 177732 0 0.0
.data 5384 5384 0 0.0
.text 1256632 1256632 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 983643 983643 0 0.0
bss 120860 120860 0 0.0
rodata 116480 116480 0 0.0
text 668512 668512 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 967507 967507 0 0.0
bss 117904 117904 0 0.0
rodata 108016 108016 0 0.0
text 663184 663184 0 0.0
nrf52840dongle_nrf52840 (read/write) 999731 999731 0 0.0
bss 122032 122032 0 0.0
rodata 115332 115332 0 0.0
text 673900 673900 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 892866 892866 0 0.0
bss 117648 117648 0 0.0
rodata 109780 109780 0 0.0
text 584692 584692 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 916227 916227 0 0.0
bss 119240 119240 0 0.0
rodata 105120 105120 0 0.0
text 614460 614460 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 826246 826246 0 0.0
bss 116056 116056 0 0.0
rodata 98344 98344 0 0.0
text 531412 531412 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 918883 918883 0 0.0
bss 118984 118984 0 0.0
rodata 105504 105504 0 0.0
text 616924 616924 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 914067 914067 0 0.0
bss 119012 119012 0 0.0
rodata 104608 104608 0 0.0
text 612956 612956 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798219 798219 0 0.0
bss 109776 109776 0 0.0
rodata 78288 78288 0 0.0
text 533652 533652 0 0.0
p6 all-clusters-app default (read/write) 2415424 2415424 0 0.0
.bss 117924 117924 0 0.0
.data 2584 2584 0 0.0
.text 1373688 1373688 0 0.0
light-app default (read/write) 2338904 2338904 0 0.0
.bss 105684 105684 0 0.0
.data 2408 2408 0 0.0
.text 1297168 1297168 0 0.0
lock-app default (read/write) 2304440 2304440 0 0.0
.bss 105428 105428 0 0.0
.data 2360 2360 0 0.0
.text 1262704 1262704 0 0.0
qpg lighting-app qpg6105+debug (read only) 571964 571964 0 0.0
(read/write) 146936 146936 0 0.0
.bss 89840 89840 0 0.0
.data 1060 1060 0 0.0
.text 566644 566644 0 0.0
lock-app qpg6105+debug (read only) 518060 518060 0 0.0
(read/write) 146940 146940 0 0.0
.bss 89312 89312 0 0.0
.data 992 992 0 0.0
.text 512740 512740 0 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 848046 848046 0 0.0
bss 87640 87640 0 0.0
noinit 37160 37160 0 0.0
text 592818 592818 0 0.0

@woody-apple
Copy link
Contributor

Fast tracking platform & test changes.

@woody-apple woody-apple merged commit a255464 into project-chip:master Jan 27, 2022
@bzbarsky-apple bzbarsky-apple deleted the darwin-test-timeouts branch January 27, 2022 04:44
selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
@bzbarsky-apple @selissia
Make the Darwin per-step YAML timeouts larger and configurable. (proj…
1dd4e77 
…ect-chip#14368)

This makes the following changes:

1) Bumps kTimeoutInSeconds from 3 to 5.
2) For "WaitForMs" commands, sets the timeout to
   (waitTime/1000) + kTimeoutInSeconds, so longish waits work automatically.
3) Allows specifying a "stepTimeoutSecs" property in the YAML to override
   all of that and just set a value.

Fixes project-chip#14364
Fixes project-chip#14260
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@raju-apple raju-apple Awaiting requested review from raju-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
darwin fast track review - pending
Projects
None yet
Milestone
No milestone
2 participants
@bzbarsky-apple @woody-apple