-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functionality to read attributes from content apps #19924
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mrjerryjohns and
msandstedt
June 23, 2022 21:54
andy31415
reviewed
Jun 24, 2022
andy31415
reviewed
Jun 24, 2022
PR #19924: Size comparison from eaafe61 to 4c364e5 Increases (2 builds for cyw30739, esp32)
Decreases (2 builds for nrfconnect, telink)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #19924: Size comparison from e5e09f5 to 4381be0 Increases (4 builds for cc13x2_26x2, nrfconnect, telink)
Decreases (3 builds for cc13x2_26x2, cyw30739)
Full report (39 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #19924: Size comparison from 72b3f53 to 0990400 Decreases (2 builds for esp32, nrfconnect)
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #19924: Size comparison from 9b3668c to c3a6425 Increases (2 builds for cyw30739, esp32)
Decreases (4 builds for nrfconnect, telink)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
andy31415
reviewed
Jun 28, 2022
examples/tv-app/android/include/content-launcher/AppContentLauncherManager.cpp
Outdated
Show resolved
Hide resolved
andy31415
reviewed
Jun 28, 2022
andy31415
reviewed
Jun 28, 2022
examples/tv-app/android/include/content-launcher/AppContentLauncherManager.cpp
Outdated
Show resolved
Hide resolved
andy31415
reviewed
Jun 28, 2022
examples/tv-app/android/include/content-launcher/AppContentLauncherManager.cpp
Outdated
Show resolved
Hide resolved
woody-apple
approved these changes
Jun 28, 2022
PR #19924: Size comparison from 6e6892a to b4cde44 Increases (4 builds for cc13x2_26x2, nrfconnect, telink)
Decreases (1 build for cc13x2_26x2)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Functionality for reading attributes from content apps was missing in the tv-app example
Change overview
Added mechanism to send attribute read requests to content app and send the response back to the client. One cluster attributes were implemented as an example.
Testing
Manually using the tv-casting-app