Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Fix ReadClient to use the right parameters when computing the liveness timeout #22699

Merged
merged 2 commits into from
Sep 20, 2022
Merged

[BUG] Fix ReadClient to use the right parameters when computing the liveness timeout #22699

merged 2 commits into from
Sep 20, 2022

Commits on Sep 19, 2022

  1. Fix ReadClient to use the right parameters when computing the liveness 

    timeout

This fixes the logic in ReadClient to use the local IDLE interval when
computing the liveness timeout instead of the IDLE interval of our peer.

Testing:

Using the REPL and the liveness timer print, confirmed the fixes are
indeed applied.

Restyled by whitespace

Restyled by clang-format

Build fixes
    @mrjerryjohns
    mrjerryjohns committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    5ea8571 View commit details
    Browse the repository at this point in the history

  2. Review feedback

    @mrjerryjohns
    mrjerryjohns committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    a6254f4 View commit details
    Browse the repository at this point in the history