Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Silabs][SiWx917] Fix log disabling and the lock-app build #25622

Merged

Conversation

jmartinez-silabs
Copy link
Member

A few fixes for the silabs SiWx917 wifi platform

  • Logs could not be disabled by the common silabs build an argument for the 917: Add the arg and define in the platform gni
  • Disabling said log caused some undefined functions for that platform: Fix some ifdefs
  • Some of the latest lock-app changes were not fully applied to the siwx917 platform: Update the header

@github-actions
Copy link

PR #25622: Size comparison from bdee2ef to 338fdb9

Full report (1 build for cc32xx)
platform target config section bdee2ef 338fdb9 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 644945 644945 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930293 930293 0 0.0
.debug_aranges 87376 87376 0 0.0
.debug_frame 300236 300236 0 0.0
.debug_info 20275029 20275029 0 0.0
.debug_line 2660914 2660914 0 0.0
.debug_loc 2804674 2804674 0 0.0
.debug_ranges 283248 283248 0 0.0
.debug_str 3026077 3026077 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105921 105921 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 379152 379152 0 0.0
.symtab 256848 256848 0 0.0
.text 536904 536904 0 0.0

@github-actions
Copy link

PR #25622: Size comparison from 3c6bed3 to d42a152

Decreases (1 build for cc32xx)
platform target config section 3c6bed3 d42a152 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20275631 20275630 -1 -0.0
Full report (1 build for cc32xx)
platform target config section 3c6bed3 d42a152 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645097 645097 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930293 930293 0 0.0
.debug_aranges 87384 87384 0 0.0
.debug_frame 300248 300248 0 0.0
.debug_info 20275631 20275630 -1 -0.0
.debug_line 2660982 2660982 0 0.0
.debug_loc 2804957 2804957 0 0.0
.debug_ranges 283168 283168 0 0.0
.debug_str 3026158 3026158 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105993 105993 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 379204 379204 0 0.0
.symtab 256912 256912 0 0.0
.text 536984 536984 0 0.0

@jmartinez-silabs jmartinez-silabs merged commit 4892a51 into project-chip:master Mar 11, 2023
@jmartinez-silabs jmartinez-silabs deleted the siwx917/disable_logs branch March 11, 2023 00:18
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
mwswartwout pushed a commit to mwswartwout/connectedhomeip that referenced this pull request Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants