-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Followup #27318 - Fix review comments that came in after landing #27483
Conversation
PR #27483: Size comparison from 2dd4fdb to 8e9bfd5 Increases (6 builds for bl702, esp32, psoc6, telink)
Decreases (12 builds for bl702l, esp32, psoc6, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
8e9bfd5
to
85a18dd
Compare
PR #27483: Size comparison from 2dd4fdb to 85a18dd Increases (11 builds for bl602, bl702, esp32, psoc6, qpg, telink)
Decreases (11 builds for bl702, bl702l, esp32, psoc6, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
85a18dd
to
f8f4d4d
Compare
PR #27483: Size comparison from 3543f06 to f8f4d4d Increases (8 builds for esp32, psoc6, qpg, telink)
Decreases (11 builds for bl602, bl702, psoc6, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
f8f4d4d
to
0dbbd31
Compare
PR #27483: Size comparison from 23a0064 to 0dbbd31 Increases (10 builds for bl602, bl702, cc32xx, psoc6, telink)
Decreases (7 builds for esp32, psoc6, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
0dbbd31
to
710f4e6
Compare
PR #27483: Size comparison from 7ae5919 to 710f4e6 Increases (11 builds for bl702, bl702l, psoc6, qpg, telink)
Decreases (8 builds for bl602, esp32, psoc6, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
710f4e6
to
5501901
Compare
PR #27483: Size comparison from b3002c6 to 5501901 Increases (11 builds for bl602, bl702l, nrfconnect, psoc6, qpg, telink)
Decreases (6 builds for esp32, nrfconnect, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
b68516c
to
657db8a
Compare
PR #27483: Size comparison from a85c19f to 657db8a Increases (11 builds for bl602, bl702, cc32xx, psoc6, telink)
Decreases (6 builds for esp32, psoc6, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
657db8a
to
4398851
Compare
PR #27483: Size comparison from a85c19f to 4398851 Increases (9 builds for bl602, cc32xx, psoc6, qpg, telink)
Decreases (7 builds for bl702l, nrfconnect, psoc6, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
4398851
to
6adfd1d
Compare
PR #27483: Size comparison from a85c19f to 6adfd1d Increases (5 builds for bl602, bl702, psoc6, qpg)
Decreases (3 builds for cc32xx, esp32, qpg)
Full report (42 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
6adfd1d
to
94222de
Compare
PR #27483: Size comparison from a85c19f to 94222de Increases (9 builds for bl602, bl702, cc32xx, psoc6, qpg, telink)
Decreases (5 builds for bl702l, esp32, nrfconnect, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
94222de
to
f7fccde
Compare
PR #27483: Size comparison from fa07cc9 to f7fccde Increases (10 builds for bl702, esp32, nrfconnect, psoc6, telink)
Decreases (8 builds for bl602, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Problem
Some review comments for #27318 came in post landing. This PR address most of them but there is still the case about the name resolution failing. There is not callback for that yet and I would like to do a separated PR for it.