Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add laundry-washer-controls-cluster server implementation #27503

Merged
merged 29 commits into from
Jul 22, 2023
Merged

Add laundry-washer-controls-cluster server implementation #27503

merged 29 commits into from
Jul 22, 2023

Conversation

crlonxp
Copy link
Contributor

@crlonxp crlonxp commented Jun 27, 2023

No description provided.

@github-actions github-actions bot added the app label Jun 27, 2023
@crlonxp
* Remove the unused definition for storage-key-alloc
bbe0590 
Signed-off-by: Chin-Ran Lo <chin-ran.lo@nxp.com>
bzbarsky-apple
bzbarsky-apple reviewed Jul 21, 2023
View reviewed changes
src/app/clusters/laundry-washer-controls-server/laundry-washer-controls-delegate.h Outdated Show resolved Hide resolved
src/app/clusters/laundry-washer-controls-server/laundry-washer-controls-delegate.h Outdated Show resolved Hide resolved
src/app/clusters/laundry-washer-controls-server/laundry-washer-controls-delegate.h Show resolved Hide resolved
src/app/clusters/laundry-washer-controls-server/laundry-washer-controls-server.h Outdated Show resolved Hide resolved
src/app/clusters/laundry-washer-controls-server/laundry-washer-controls-server.h Outdated Show resolved Hide resolved
src/app/clusters/laundry-washer-controls-server/laundry-washer-controls-server.cpp Outdated Show resolved Hide resolved
src/app/clusters/laundry-washer-controls-server/laundry-washer-controls-server.cpp Show resolved Hide resolved
src/app/clusters/laundry-washer-controls-server/laundry-washer-controls-server.cpp Outdated Show resolved Hide resolved
src/app/clusters/laundry-washer-controls-server/laundry-washer-controls-server.cpp Outdated Show resolved Hide resolved
src/app/clusters/laundry-washer-controls-server/laundry-washer-controls-server.cpp Outdated Show resolved Hide resolved
crlonxp and others added 7 commits July 22, 2023 11:31
@crlonxp @bzbarsky-apple
Update src/app/clusters/laundry-washer-controls-server/laundry-washer…
72d6279 
…-controls-server.cpp

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
@crlonxp @bzbarsky-apple
Update src/app/clusters/laundry-washer-controls-server/laundry-washer…
9f38b00 
…-controls-server.h

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
@crlonxp @bzbarsky-apple
Update src/app/clusters/laundry-washer-controls-server/laundry-washer…
f619a52 
…-controls-server.h

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
@crlonxp @bzbarsky-apple
Update src/app/clusters/laundry-washer-controls-server/laundry-washer…
b4f1b01 
…-controls-server.cpp

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
@crlonxp @bzbarsky-apple
Update src/app/clusters/laundry-washer-controls-server/laundry-washer…
402da53 
…-controls-server.cpp

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
@crlonxp
* Use MutableCharSpan to replace CharSpan
db5a449 
* Add to calculate the delegate id from endpoint

Signed-off-by: Chin-Ran Lo <chin-ran.lo@nxp.com>
@restyled-commits @crlonxp
Restyled by clang-format
550253f
@crlonxp
* Refine the comment
cc8b13f 
Signed-off-by: Chin-Ran Lo <chin-ran.lo@nxp.com>
bzbarsky-apple
bzbarsky-apple approved these changes Jul 22, 2023
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but please do fix the documentation. In particular "list of supported spin_speed list" does not make sense, and similar for rinses.

src/app/clusters/laundry-washer-controls-server/laundry-washer-controls-delegate.h Outdated Show resolved Hide resolved
src/app/clusters/laundry-washer-controls-server/laundry-washer-controls-server.h Outdated Show resolved Hide resolved
src/app/clusters/laundry-washer-controls-server/laundry-washer-controls-server.h Outdated Show resolved Hide resolved
src/app/clusters/laundry-washer-controls-server/laundry-washer-controls-server.h Outdated Show resolved Hide resolved
src/app/clusters/laundry-washer-controls-server/laundry-washer-controls-server.h Show resolved Hide resolved
crlonxp and others added 4 commits July 22, 2023 14:40
@crlonxp @bzbarsky-apple
Update src/app/clusters/laundry-washer-controls-server/laundry-washer…
de033f2 
…-controls-server.h

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
@crlonxp @bzbarsky-apple
Update src/app/clusters/laundry-washer-controls-server/laundry-washer…
1da8c1a 
…-controls-server.h

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
@crlonxp @bzbarsky-apple
Update src/app/clusters/laundry-washer-controls-server/laundry-washer…
866b712 
…-controls-server.h

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
@restyled-commits @crlonxp
Restyled by clang-format
3703648
@mergify mergify bot merged commit 9d053d3 into project-chip:master Jul 22, 2023
andy31415
andy31415 reviewed Jul 22, 2023
View reviewed changes
src/app/clusters/laundry-washer-controls-server/laundry-washer-controls-server.h
*
* @param endpointId ID of the endpoint
* @param SpinSpeedCurrent attribute SpinSpeedCurrent
* @return true on success, false on failure
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commenting post merge, so I do not block the PR: these return EmberAfStatus, so probably not true on success/false on failure. Also the comment seems redundant - when something returns CHIP_ERROR or EmberAfStatus the return is reasonably clear.

Overall we can save vertical space a lot (it is obvious GetSpinSpeedCurrent gets the speed speed current). I guess it is unclear what newSpinSpeedCurrent is (what is new) but the comment does not help me much ... it seems everything is called newSpinSpeedCurrent.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the suggestions. I will change these in the next PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I add the change in #28264
Please review. Thank you

@github-actions
Copy link

github-actions bot commented Jul 24, 2023 •
edited
Loading

PR #27503: Size comparison from 0760d13 to 3703648

Increases (6 builds for k32w, nrfconnect, telink)
platform target config section 0760d13 3703648 change % change
k32w contact k32w0+release (read only) 587316 587332 16 0.0
.text 586780 586796 16 0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1152128 1152144 16 0.0
text 807356 807360 4 0.0
telink all-clusters-app tlsr9518adk80d text 721692 721694 2 0.0
light-switch-app tlsr9518adk80d (read/write) 900380 900388 8 0.0
text 613106 613110 4 0.0
lighting-app-factory-data tlsr9518adk80d text 690486 690490 4 0.0
window-covering tlsr9518adk80d text 613524 613526 2 0.0
Decreases (13 builds for bl602, bl702, cc32xx, nrfconnect, psoc6, telink)
platform target config section 0760d13 3703648 change % change
bl602 lighting-app bl602+rpc .text 1085816 1085814 -2 -0.0
bl702 lighting-app bl702+rpc .debug_info 45838510 45838509 -1 -0.0
.text 1024980 1024978 -2 -0.0
cc32xx lock CC3235SF_LAUNCHXL .debug_info 18640781 18640780 -1 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1209156 1209140 -16 -0.0
text 837180 837176 -4 -0.0
psoc6 light cy8ckit_062s2_43012 .debug_info 21865311 21865310 -1 -0.0
lock cy8ckit_062s2_43012 .debug_info 21461342 21461341 -1 -0.0
telink all-clusters-minimal-app tlsr9518adk80d (read/write) 971736 971728 -8 -0.0
text 666482 666480 -2 -0.0
lighting-app tlsr9518adk80d text 682972 682970 -2 -0.0
lighting-app-rpc tlsr9518adk80d text 727864 727860 -4 -0.0
ota-requestor-app tlsr9518adk80d text 609350 609348 -2 -0.0
shell tlsr9518adk80d text 478580 478578 -2 -0.0
smoke_co_alarm-app tlsr9518adk80d text 590520 590516 -4 -0.0
temperature-measurement-app tlsr9518adk80d (read/write) 860260 860252 -8 -0.0
text 579190 579188 -2 -0.0
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 0760d13 3703648 change % change
bl602 lighting-app bl602 (read/write) 1358422 1358422 0 0.0
.bss 72398 72398 0 0.0
.data 9608 9608 0 0.0
.text 1053676 1053676 0 0.0
bl602+rpc (read/write) 1406090 1406090 0 0.0
.bss 80438 80438 0 0.0
.data 10008 10008 0 0.0
.text 1085816 1085814 -2 -0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1161459 1161459 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 41237 41237 0 0.0
.bss_psram 42432 42432 0 0.0
.comment 48 48 0 0.0
.data 3600 3600 0 0.0
.debug_abbrev 1554778 1554778 0 0.0
.debug_aranges 139848 139848 0 0.0
.debug_frame 514308 514308 0 0.0
.debug_info 40632847 40632847 0 0.0
.debug_line 5432848 5432848 0 0.0
.debug_loc 3551244 3551244 0 0.0
.debug_ranges 383336 383336 0 0.0
.debug_str 3980648 3980648 0 0.0
.hbn 544 544 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 140 140 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 105884 105884 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 584041 584041 0 0.0
.symtab 174480 174480 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
950572 950572 0 0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1260071 1260071 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 49685 49685 0 0.0
.bss_psram 42432 42432 0 0.0
.comment 48 48 0 0.0
.data 4144 4144 0 0.0
.debug_abbrev 1720307 1720307 0 0.0
.debug_aranges 148360 148360 0 0.0
.debug_frame 543160 543160 0 0.0
.debug_info 45838510 45838509 -1 -0.0
.debug_line 5860181 5860181 0 0.0
.debug_loc 3757170 3757170 0 0.0
.debug_ranges 409080 409080 0 0.0
.debug_str 4411036 4411036 0 0.0
.hbn 544 544 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 156 156 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 120536 120536 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 646982 646982 0 0.0
.symtab 193392 193392 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1024980 1024978 -2 -0.0
bl702l lighting-app bl702l (read only) 278 278 0 0.0
(read/write) 1147024 1147024 0 0.0
.boot2 292 292 0 0.0
.bss 15924 15924 0 0.0
.bss_psram 76848 76848 0 0.0
.comment 48 48 0 0.0
.data 4568 4568 0 0.0
.debug_abbrev 1556997 1556997 0 0.0
.debug_aranges 134352 134352 0 0.0
.debug_frame 493996 493996 0 0.0
.debug_info 40633956 40633956 0 0.0
.debug_line 5348386 5348386 0 0.0
.debug_loc 3487395 3487395 0 0.0
.debug_ranges 388544 388544 0 0.0
.debug_str 3993105 3993105 0 0.0
.hbn 3244 3244 0 0.0
.hbn_noinit 308 308 0 0.0
.init 408 408 0 0.0
.init_array 140 140 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 99768 99768 0 0.0
.romdata 3224 3224 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 286 286 0 0.0
.stack 2048 2048 0 0.0
.strtab 584266 584266 0 0.0
.symtab 174048 174048 0 0.0
.tcm_data 692 692 0 0.0
.tcmcode 278 278 0 0.0
.text 0 0 0 0.0
939374 939374 0 0.0
cc32xx lock CC3235SF_LAUNCHXL (read only) 608610 608610 0 0.0
(read/write) 204628 204628 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 198040 198040 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 945745 945745 0 0.0
.debug_aranges 107624 107624 0 0.0
.debug_frame 365364 365364 0 0.0
.debug_info 18640781 18640780 -1 -0.0
.debug_line 2748932 2748932 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1576235 1576235 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 99157 99157 0 0.0
.debug_str 3406318 3406318 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105026 105026 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 485397 485397 0 0.0
.symtab 288272 288272 0 0.0
.text 0 0 0 0.0
501460 501460 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 546519 546519 0 0.0
.app_xip_area 438657 438657 0 0.0
.bss 62832 62832 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 530591 530591 0 0.0
.app_xip_area 417777 417777 0 0.0
.bss 67776 67776 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 569719 569719 0 0.0
.app_xip_area 462945 462945 0 0.0
.bss 61792 61792 0 0.0
.data 668 668 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 542959 542959 0 0.0
.app_xip_area 433217 433217 0 0.0
.bss 64680 64680 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1005480 1005480 0 0.0
.bss 182444 182444 0 0.0
.data 2696 2696 0 0.0
.text 820320 820320 0 0.0
BRD4187C (read/write) 1031024 1031024 0 0.0
.bss 162196 162196 0 0.0
.data 3292 3292 0 0.0
.text 865516 865516 0 0.0
lock-app BRD4161A+wf200 (read/write) 1080564 1080564 0 0.0
.bss 176452 176452 0 0.0
.data 2692 2692 0 0.0
.text 901400 901400 0 0.0
window-app BRD4187C (read/write) 1101640 1101640 0 0.0
.bss 145188 145188 0 0.0
.data 3204 3204 0 0.0
.text 953228 953228 0 0.0
esp32 all-clusters-app c3devkit (read only) 1091270 1091270 0 0.0
(read/write) 1587136 1587136 0 0.0
.dram0.bss 76128 76128 0 0.0
.dram0.data 13988 13988 0 0.0
.flash.rodata 217880 217880 0 0.0
.flash.text 1091270 1091270 0 0.0
.iram0.text 76740 76740 0 0.0
m5stack (read only) 1137963 1137963 0 0.0
(read/write) 497582 497582 0 0.0
.dram0.bss 81624 81624 0 0.0
.dram0.data 34344 34344 0 0.0
.flash.rodata 246464 246464 0 0.0
.flash.text 1132579 1132579 0 0.0
.iram0.text 126055 126055 0 0.0
k32w contact k32w0+release (read only) 587316 587332 16 0.0
(read/write) 90424 90424 0 0.0
.bss 66428 66428 0 0.0
.data 2168 2168 0 0.0
.text 586780 586796 16 0.0
light k32w0+release (read only) 586084 586084 0 0.0
(read/write) 90072 90072 0 0.0
.bss 66092 66092 0 0.0
.data 2156 2156 0 0.0
.text 585548 585548 0 0.0
lock k32w0+release (read only) 558524 558524 0 0.0
(read/write) 87880 87880 0 0.0
.bss 63956 63956 0 0.0
.data 2100 2100 0 0.0
.text 557988 557988 0 0.0
linux all-clusters-app debug (read only) 5459249 5459249 0 0.0
(read/write) 416576 416576 0 0.0
.bss 130112 130112 0 0.0
.data 4432 4432 0 0.0
.data.rel.ro 274728 274728 0 0.0
.dynamic 624 624 0 0.0
.got 5384 5384 0 0.0
.init 27 27 0 0.0
.init_array 1272 1272 0 0.0
.rodata 330960 330960 0 0.0
.text 4753011 4753011 0 0.0
all-clusters-minimal-app debug (read only) 4885017 4885017 0 0.0
(read/write) 230568 230568 0 0.0
.bss 125440 125440 0 0.0
.data 4304 4304 0 0.0
.data.rel.ro 93696 93696 0 0.0
.dynamic 624 624 0 0.0
.got 5344 5344 0 0.0
.init 27 27 0 0.0
.init_array 1120 1120 0 0.0
.rodata 270694 270694 0 0.0
.text 4385347 4385347 0 0.0
bridge-app debug (read only) 2754025 2754025 0 0.0
(read/write) 132224 132224 0 0.0
.bss 50520 50520 0 0.0
.data 4880 4880 0 0.0
.data.rel.ro 70720 70720 0 0.0
.dynamic 624 624 0 0.0
.got 4640 4640 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 213184 213184 0 0.0
.text 2364515 2364515 0 0.0
chip-tool debug (read only) 17611105 17611105 0 0.0
(read/write) 1050864 1050864 0 0.0
.bss 93560 93560 0 0.0
.data 5154 5154 0 0.0
.data.rel.ro 944824 944824 0 0.0
.dynamic 624 624 0 0.0
.got 5880 5880 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 907529 907529 0 0.0
.text 14658291 14658291 0 0.0
chip-tool-ipv6only arm64 (read only) 16836724 16836724 0 0.0
(read/write) 1118344 1118344 0 0.0
.bss 102968 102968 0 0.0
.data 4448 4448 0 0.0
.data.rel.ro 982192 982192 0 0.0
.dynamic 512 512 0 0.0
.got 23248 23248 0 0.0
.init 24 24 0 0.0
.init_array 240 240 0 0.0
.rodata 819488 819488 0 0.0
.text 13787768 13787768 0 0.0
lighting-app debug+rpc+ui (read only) 5219713 5219713 0 0.0
(read/write) 220824 220824 0 0.0
.bss 117424 117424 0 0.0
.data 4848 4848 0 0.0
.data.rel.ro 91016 91016 0 0.0
.dynamic 672 672 0 0.0
.got 5904 5904 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 332212 332212 0 0.0
.text 4647859 4647859 0 0.0
lock-app debug (read only) 4442569 4442569 0 0.0
(read/write) 201440 201440 0 0.0
.bss 112816 112816 0 0.0
.data 4048 4048 0 0.0
.data.rel.ro 77816 77816 0 0.0
.dynamic 624 624 0 0.0
.got 5264 5264 0 0.0
.init 27 27 0 0.0
.init_array 840 840 0 0.0
.rodata 245854 245854 0 0.0
.text 3989379 3989379 0 0.0
ota-provider-app debug (read only) 4112673 4112673 0 0.0
(read/write) 191248 191248 0 0.0
.bss 113344 113344 0 0.0
.data 4256 4256 0 0.0
.data.rel.ro 67760 67760 0 0.0
.dynamic 624 624 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 199678 199678 0 0.0
.text 3723875 3723875 0 0.0
ota-requestor-app debug (read only) 4206665 4206665 0 0.0
(read/write) 195560 195560 0 0.0
.bss 114272 114272 0 0.0
.data 4624 4624 0 0.0
.data.rel.ro 70760 70760 0 0.0
.dynamic 624 624 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 203070 203070 0 0.0
.text 3810147 3810147 0 0.0
shell debug (read only) 2905713 2905713 0 0.0
(read/write) 149640 149640 0 0.0
.bss 59368 59368 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 83152 83152 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 1112 1112 0 0.0
.rodata 209490 209490 0 0.0
.text 2526834 2526834 0 0.0
thermostat-no-ble arm64 (read only) 4436124 4436124 0 0.0
(read/write) 243240 243240 0 0.0
.bss 122088 122088 0 0.0
.data 3200 3200 0 0.0
.data.rel.ro 101592 101592 0 0.0
.dynamic 512 512 0 0.0
.got 11896 11896 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 161172 161172 0 0.0
.text 3938536 3938536 0 0.0
tv-app debug (read only) 5299969 5299969 0 0.0
(read/write) 349296 349296 0 0.0
.bss 240288 240288 0 0.0
.data 6224 6224 0 0.0
.data.rel.ro 95376 95376 0 0.0
.dynamic 624 624 0 0.0
.got 5616 5616 0 0.0
.init 27 27 0 0.0
.init_array 1128 1128 0 0.0
.rodata 271190 271190 0 0.0
.text 4786339 4786339 0 0.0
tv-casting-app debug (read only) 8273289 8273289 0 0.0
(read/write) 209240 209240 0 0.0
.bss 53952 53952 0 0.0
.data 2896 2896 0 0.0
.data.rel.ro 145608 145608 0 0.0
.dynamic 624 624 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 366204 366204 0 0.0
.text 7510019 7510019 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2515912 2515912 0 0.0
.bss 216776 216776 0 0.0
.data 5152 5152 0 0.0
.text 1478596 1478596 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1209156 1209140 -16 -0.0
bss 153600 153600 0 0.0
rodata 139352 139352 0 0.0
text 837180 837176 -4 -0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1329368 1329368 0 0.0
bss 138914 138914 0 0.0
rodata 134496 134496 0 0.0
text 765184 765184 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1152128 1152144 16 0.0
bss 153810 153810 0 0.0
rodata 111940 111940 0 0.0
text 807356 807360 4 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 840816 840816 0 0.0
(read/write) 1752332 1752332 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189900 189900 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2624 2624 0 0.0
.debug_abbrev 1358136 1358136 0 0.0
.debug_aranges 142528 142528 0 0.0
.debug_frame 475296 475296 0 0.0
.debug_info 29007647 29007647 0 0.0
.debug_line 4063426 4063426 0 0.0
.debug_line_str 957 957 0 0.0
.debug_loclists 2230731 2230731 0 0.0
.debug_rnglists 141012 141012 0 0.0
.debug_str 4118459 4118459 0 0.0
.heap 840816 840816 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 784117 784117 0 0.0
.symtab 492016 492016 0 0.0
.text 1551420 1551420 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842720 842720 0 0.0
(read/write) 1667084 1667084 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188060 188060 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2560 2560 0 0.0
.debug_abbrev 1285465 1285465 0 0.0
.debug_aranges 136624 136624 0 0.0
.debug_frame 460656 460656 0 0.0
.debug_info 26659058 26659058 0 0.0
.debug_line 3919290 3919290 0 0.0
.debug_line_str 981 981 0 0.0
.debug_loclists 2139696 2139696 0 0.0
.debug_rnglists 134758 134758 0 0.0
.debug_str 3962841 3962841 0 0.0
.heap 842720 842720 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 706274 706274 0 0.0
.symtab 462784 462784 0 0.0
.text 1468076 1468076 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 848928 848928 0 0.0
(read/write) 1598940 1598940 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 182020 182020 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2392 2392 0 0.0
.debug_abbrev 1121514 1121514 0 0.0
.debug_aranges 126872 126872 0 0.0
.debug_frame 424260 424260 0 0.0
.debug_info 21865311 21865310 -1 -0.0
.debug_line 3487464 3487464 0 0.0
.debug_line_str 942 942 0 0.0
.debug_loclists 1978641 1978641 0 0.0
.debug_rnglists 124646 124646 0 0.0
.debug_str 3773157 3773157 0 0.0
.heap 848928 848928 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 627850 627850 0 0.0
.symtab 427728 427728 0 0.0
.text 1406140 1406140 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 821496 821496 0 0.0
(read/write) 1628212 1628212 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 209452 209452 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2392 2392 0 0.0
.debug_abbrev 1098508 1098508 0 0.0
.debug_aranges 124816 124816 0 0.0
.debug_frame 417092 417092 0 0.0
.debug_info 21461342 21461341 -1 -0.0
.debug_line 3415298 3415298 0 0.0
.debug_line_str 933 933 0 0.0
.debug_loclists 1945897 1945897 0 0.0
.debug_rnglists 121986 121986 0 0.0
.debug_str 3727517 3727517 0 0.0
.heap 821496 821496 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 596871 596871 0 0.0
.symtab 417264 417264 0 0.0
.text 1407980 1407980 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1174296 1174296 0 0.0
.bss 100280 100280 0 0.0
.data 788 788 0 0.0
.text 621136 621136 0 0.0
lock-app qpg6105+debug (read/write) 1131296 1131296 0 0.0
.bss 95008 95008 0 0.0
.data 792 792 0 0.0
.text 578140 578140 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1059816 1059816 0 0.0
bss 106264 106264 0 0.0
text 721692 721694 2 0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 971736 971728 -8 -0.0
bss 104276 104276 0 0.0
text 666482 666480 -2 -0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 939580 939580 0 0.0
bss 108288 108288 0 0.0
text 644130 644130 0 0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 871484 871484 0 0.0
bss 97952 97952 0 0.0
text 587458 587458 0 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 900380 900388 8 0.0
bss 98508 98508 0 0.0
text 613106 613110 4 0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 977924 977924 0 0.0
bss 106628 106628 0 0.0
text 682972 682970 -2 -0.0
lighting-app-factory-data tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 989296 989296 0 0.0
bss 110876 110876 0 0.0
text 690486 690490 4 0.0
lighting-app-rpc tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1047408 1047408 0 0.0
bss 108184 108184 0 0.0
text 727864 727860 -4 -0.0
lighting-app-shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1078776 1078776 0 0.0
bss 119268 119268 0 0.0
text 748010 748010 0 0.0
lock-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 925680 925680 0 0.0
bss 98588 98588 0 0.0
text 615250 615250 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 894124 894124 0 0.0
bss 99232 99232 0 0.0
text 609350 609348 -2 -0.0
pump-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 876996 876996 0 0.0
bss 98084 98084 0 0.0
text 593166 593166 0 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 864128 864128 0 0.0
bss 97884 97884 0 0.0
text 583586 583586 0 0.0
shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 744292 744292 0 0.0
bss 97392 97392 0 0.0
text 478580 478578 -2 -0.0
smoke_co_alarm-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 873544 873544 0 0.0
bss 98040 98040 0 0.0
text 590520 590516 -4 -0.0
temperature-measurement-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 860260 860252 -8 -0.0
bss 97792 97792 0 0.0
text 579190 579188 -2 -0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 906196 906196 0 0.0
bss 98328 98328 0 0.0
text 618634 618634 0 0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 901556 901556 0 0.0
bss 98620 98620 0 0.0
text 613524 613526 2 0.0

bzbarsky-apple
bzbarsky-apple reviewed Jul 24, 2023
View reviewed changes
src/app/clusters/laundry-washer-controls-server/laundry-washer-controls-delegate.h
virtual ~Delegate() = default;

/**
* Get the list of supported spin_speed list.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crlonxp This was merged without addressing review comments (e.g. #27503 (comment)), even though those comments got marked resolved.

I am sorry, but I will no longer be marking your PRs as "approved if you address these comments". All comments will need to be addressed before I can approve.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I create another PR to address these remaining comments? Or should I keep modify the code I have and push?
Thank you

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I create another PR to address these remaining comments?

Yes, please, since this PR is now merged...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I add the change in #28264
Please review. Thank you

src/app/clusters/laundry-washer-controls-server/laundry-washer-controls-server.h
* @param void
* @return CHIP_ERROR CHIP_NO_ERROR on success, or corresponding error code.
*/
// CHIP_ERROR Init();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this commented-out thing here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I registered the LaundryWasherControlServer instance to registerAttributeAccessOverride() before. But it's moved to MatterLaundryWasherControlsPluginServerInitCallback() that it's no specific behavior needed for now.
Should I keep the empty function?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just remove it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the suggestion.

@crlonxp crlonxp deleted the washer-ctrl-pr branch August 10, 2023 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@fengdx4 fengdx4 fengdx4 approved these changes

@mideayanghui mideayanghui mideayanghui approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kcoppock kcoppock Awaiting requested review from kcoppock

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@hicklin hicklin Awaiting requested review from hicklin

@mhazley mhazley Awaiting requested review from mhazley

@p0fi p0fi Awaiting requested review from p0fi

@plauric plauric Awaiting requested review from plauric

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@aronrosenberg aronrosenberg Awaiting requested review from aronrosenberg

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

Assignees

@crlonxp crlonxp

Labels
app review - approved
Projects
[Device Type] Laundry Washers
Status: Done
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
8 participants
@crlonxp @marktrayer @woody-apple @andy31415 @bzbarsky-apple @mideayanghui @fengdx4 @restyled-commits